Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paths treated as hidden #8860

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

EmanuelCampos
Copy link
Contributor

@EmanuelCampos EmanuelCampos commented Nov 11, 2023

Description

Notebooks when using "../../../img_cache" is being treated as a hidden file, making it throw an error that the path doesn't have files

How to reproduce:

from llama_index.multi_modal_llms.openai import OpenAIMultiModal
from llama_index import SimpleDirectoryReader

image_documents = SimpleDirectoryReader("../../../img_cache").load_data()

Keep any image file in the img_cache directory and run (curiously when have a document it's recognized, images no (before the fix)

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I ran make format; make lint to appease the lint gods

Copy link
Contributor

@hatianzhang hatianzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hatianzhang hatianzhang merged commit 15a2840 into run-llama:main Nov 11, 2023
@ryanpeach ryanpeach mentioned this pull request Feb 7, 2024
15 tasks
ryanpeach pushed a commit to OnScale/llama_index that referenced this pull request Feb 7, 2024
* fix: paths treated as hidden

* cr

* type
@ryanpeach ryanpeach mentioned this pull request Feb 7, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants