Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remnant of Pydantic's state in getstate #8902

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

trducng
Copy link
Contributor

@trducng trducng commented Nov 14, 2023

Description

Since we don't subclass Pydantic's __getstate__, we will remove the __dict__ in our __getstate__ operation as well.
Fixes #8895

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@logan-markewich
Copy link
Collaborator

wow haha someday I will learn to read before merging my own code -- thanks!

@trducng trducng mentioned this pull request Nov 14, 2023
@logan-markewich logan-markewich merged commit e717f4c into run-llama:main Nov 14, 2023
@ryanpeach ryanpeach mentioned this pull request Feb 7, 2024
15 tasks
ryanpeach pushed a commit to OnScale/llama_index that referenced this pull request Feb 7, 2024
@ryanpeach ryanpeach mentioned this pull request Feb 7, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cannot deepcopy TextNode
2 participants