Orca 679 global atlantis lock new release branch (#49)

* Adding CommandLocker to boltDB and exposing it through locker interface

* Apply lock ui and apply command lock controller

* Minor comments

* Adding more tests and refactorinng

* Linting fixes

* creating applyLockingClient variable to fix interface error

* nullsink for stats

* Addressing PR comments

* fixing e2e tests

* linting fix fml

* Update outdated function descriptions

Address PR comments

* revert stats sink changes

server/controllers/events/events_controller_e2e_test.go

@@ -409,6 +409,11 @@ func TestGitHubWorkflow(t *testing.T) {
 				_, _ = applyLocker.LockApply()
 			}
 
+			// Create global apply lock if required
+			if c.ApplyLock {
+				_, _ = applyLocker.LockApply()
+			}
+
 			// Now send any other comments.
 			for _, comment := range c.Comments {
 				commentReq := GitHubCommentEvent(t, comment)

server/events/apply_command_runner_test.go

@@ -5,6 +5,7 @@ import (
 	"testing"
 
 	"github.com/google/go-github/v31/github"
+	stats "github.com/lyft/gostats"
 	. "github.com/petergtz/pegomock"
 	"github.com/runatlantis/atlantis/server/core/locking"
 	"github.com/runatlantis/atlantis/server/events"
@@ -46,6 +47,8 @@ func TestApplyCommandRunner_IsLocked(t *testing.T) {
 		t.Run(c.Description, func(t *testing.T) {
 			vcsClient := setup(t)
 
+			scopeNull := stats.NewStore(stats.NewNullSink(), false)
+
 			pull := &github.PullRequest{
 				State: github.String("open"),
 			}
@@ -59,6 +62,7 @@ func TestApplyCommandRunner_IsLocked(t *testing.T) {
 				Pull:     modelPull,
 				HeadRepo: fixtures.GithubRepo,
 				Trigger:  events.Comment,
+				Scope:    scopeNull,
 			}
 
 			When(applyLockChecker.CheckApplyLock()).ThenReturn(locking.ApplyCommandLock{Locked: c.ApplyLocked}, c.ApplyLockError)

server/server.go

@@ -329,6 +329,7 @@ func NewServer(userConfig UserConfig, config Config) (*Server, error) {
 		lockingClient = locking.NewNoOpLocker()
 	} else {
 		lockingClient = locking.NewClient(boltdb)
+		applyLockingClient = locking.NewApplyClient(boltdb, userConfig.DisableApply)
 	}
 	applyLockingClient = locking.NewApplyClient(boltdb, userConfig.DisableApply)
 	workingDirLocker := events.NewDefaultWorkingDirLocker()

server/testfixtures/test-repos/simple-yaml/exp-output-apply-locked.txt

@@ -0,0 +1 @@
+**Error:** Running `atlantis apply` is disabled.