Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: how to enable log streaming? #1994

Closed
alex-mozejko opened this issue Jan 12, 2022 · 5 comments
Closed

question: how to enable log streaming? #1994

alex-mozejko opened this issue Jan 12, 2022 · 5 comments
Labels
bug Something isn't working streaming-logs

Comments

@alex-mozejko
Copy link

hello,

apologies for what might be a silly question :)

i've upgraded our atlantis version to 0.18.1 and am trying to get log streaming working on github.

is there a document outlining what needs to be done in terms of atlantis or infra configuration (does atlantis require certain ports to be accessible, etc?)

atlantis is running and posting comments once an atlantis plan completes however no URLs are ever posted to the github pull request. my understanding of how this feature is meant to work might be incorrect

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

Reproduction Steps

Logs

Environment details

Additional Context

@alex-mozejko alex-mozejko added the bug Something isn't working label Jan 12, 2022
@ghost
Copy link

ghost commented Jan 12, 2022

I just recently updated to 18 also and was the same as you rather confused. However I noticed the link is in the "checks" section in github. You will see it say doing plan xxx and then a details link. that details link is the link to the stream. The only requirement is that the atlantis homepage must be reachable.

@alex-mozejko
Copy link
Author

heya @xxwassyxx , thanks for the input :)

the "checks" section in the pr has remained empty unfortunately :(

image

what does the atlantis homepage need to be reachable from? github is able to reach it (for webhooks) but we have a firewall in place so that the wider internet is unable to get there, could that be an issue maybe?

@Ka1wa
Copy link
Contributor

Ka1wa commented Jan 12, 2022

@alex-mozejko I submitted a PR to fix the external CDN dependencies. Hopefully it will be included soon! #1985

As for your checks not appearing, that's probably a totally different story. Perhaps you could look at the atlantis logs? Check permissions on your Github API keys to add checks could also be a good indicator.

@alex-mozejko
Copy link
Author

@alex-mozejko I submitted a PR to fix the external CDN dependencies. Hopefully it will be included soon! #1985

As for your checks not appearing, that's probably a totally different story. Perhaps you could look at the atlantis logs? Check permissions on your Github API keys to add checks could also be a good indicator.

aha! nice one, good stuff

@nishkrishnan
Copy link
Contributor

Closing this issue since #1985 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working streaming-logs
Projects
None yet
Development

No branches or pull requests

4 participants