Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XTerm JS to the server static files #1985

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

Ka1wa
Copy link
Contributor

@Ka1wa Ka1wa commented Jan 10, 2022

We use Atlantis in an offline environment with the AWS API through PrivateLink. We'd like to use the new real-time logs with XTerm but were having issues because scripts were being loaded through a CDN. We forked the repository and made these changes so we can now use it offline.

Changelog:

  • Downloaded all XTerm CSS and JS files and added their respective LICENSES to the source.
    • xterm.css
    • xterm-4.9.0.js
    • xterm-addon-attach-0.6.0.js
    • xterm-addon-fit-0.4.0.js
  • Updated all references from CDN to static files in 2 web templates.
  • Small fix to make dist. (On my machine it didn't generate bindata_assetfs.go but the default bindata.go. I added the -o option to have less ambiguity)
  • Regenerated bindata_assetsfs.go (Seems like this wasn't done in the previous version, there was still a lingering jquery-3.2.1)

@Ka1wa Ka1wa requested a review from a team as a code owner January 10, 2022 05:32
@nishkrishnan nishkrishnan merged commit 0092cfb into runatlantis:master Jan 12, 2022
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants