Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn in logs if atlantis.yml is used instead of atlantis.yaml #755

Closed
davidgereb opened this issue Aug 22, 2019 · 5 comments
Closed

Warn in logs if atlantis.yml is used instead of atlantis.yaml #755

davidgereb opened this issue Aug 22, 2019 · 5 comments
Labels
feature New functionality/enhancement

Comments

@davidgereb
Copy link

davidgereb commented Aug 22, 2019

Issue

Atlantis doesn't recognize the repo level config if the file is named atlantis.yml instead of atlantis.yaml.

Proposal

Warn in the logs if atlantis.yml is detected.
Make atlantis config files work with .yml file extension.

@lkysow
Copy link
Member

lkysow commented Aug 22, 2019

I think it's simpler if it's always .yaml. But I'd support a warning in the logs if one with .yml is found.

@lkysow lkysow added the feature New functionality/enhancement label Aug 22, 2019
@lkysow
Copy link
Member

lkysow commented Aug 26, 2019

I'm going to change the title then to ask for a warning.

@lkysow lkysow changed the title Add support for .yml extension Warn in logs if atlantis.yml is used instead of atlantis.yaml Aug 26, 2019
@mdcurran
Copy link

mdcurran commented Nov 2, 2019

@lkysow are we good to close this? Also my b for forgetting to use the GH "fixes" syntax.

@lkysow
Copy link
Member

lkysow commented Nov 4, 2019

Yes, I'll close it nice work!

@lkysow lkysow closed this as completed Nov 4, 2019
@lkysow
Copy link
Member

lkysow commented Nov 4, 2019

(Fixed by #816)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

3 participants