Log warning when atlantis.yml is used as config #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
==========================================
+ Coverage 71.81% 71.83% +0.01%
==========================================
Files 65 65
Lines 5209 5190 -19
==========================================
- Hits 3741 3728 -13
+ Misses 1183 1179 -4
+ Partials 285 283 -2
Continue to review full report at Codecov.
|
lkysow
requested changes
Oct 28, 2019
lkysow
approved these changes
Oct 29, 2019
|
Commits have been squashed! |
|
Nice work! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log a warning whenever there is an
atlantis.ymlfile in the repository directory. The implementation is a bit naive since it will check for this invalid file extension each time Atlantis builds plan contexts, but I found it to be the easiest implementation without refactoring a bunch of functions.I'm not too hot about the
InvalidAtlantisYAMLFileExtensionconstant. It works well for reducing code duplication, but not sure having it be a global variable is a good thing. Thoughts would be welcome on this!Addresses the discussion in #755