Error when commit comment is added

[Moncky]

I am using atlantis 0.10.1 and Gitlab
When I create an initial merge requests things work as expected and I get a merge request with the appropriate changes noted in the output.

If, however, I add a coment for atlantis plan or atlantis apply I get the following errors in the logs:

2019/11/18 16:24:14+0000 [INFO] middleware.go:38 server: POST /events – from 10.0.0.16:45234
2019/11/18 16:24:14+0000 [DBUG] events_controller.go:103 server: Handling GitLab post
2019/11/18 16:24:14+0000 [WARN] events_controller.go:372 server: Json: cannot unmarshal bool into Go struct field .merge_request.merge_params.force_remove_source_branch of type string
2019/11/18 16:24:14+0000 [INFO] middleware.go:42 server: POST /events – respond HTTP 400

I have attempted to have a look at the code, however my golang is not really existent.

[lkysow]

I think this is a duplicate of #760 Can you update Atlantis?

…

On Mon, Nov 18, 2019, 9:16 AM Callum Scott ***@***.***> wrote: I am using atlantis 0.10.1 and Gitlab When I create an initial merge requests things work as expected and I get a merge request with the appropriate changes noted in the output. If, however, I add a coment for atlantis plan or atlantis apply I get the following errors in the logs: 2019/11/18 16:24:14+0000 [INFO] middleware.go:38 server: POST /events – from 10.0.0.16:45234 2019/11/18 16:24:14+0000 [DBUG] events_controller.go:103 server: Handling GitLab post 2019/11/18 16:24:14+0000 [WARN] events_controller.go:372 server: Json: cannot unmarshal bool into Go struct field .merge_request.merge_params.force_remove_source_branch of type string 2019/11/18 16:24:14+0000 [INFO] middleware.go:42 server: POST /events – respond HTTP 400 I have attempted to have a look at the code, however my golang is not really existent. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#846?email_source=notifications&email_token=AAH4RPN3LKKUJWS6TXRISO3QULEYLA5CNFSM4JOWXXLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2DJVDA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH4RPLS5TXUXRJN4YDREQLQULEYLANCNFSM4JOWXXLA> .

[Moncky]

I’m running 0.10.1 via the official docker image. That fix was in 0.10.0 as far as I can see. I did have a look at this and suspect it’s a similar issue but haven’t been able to trace it back

[lkysow]

Hmmm, maybe we regressed somehow. Okay I'll take a look.

…

On Mon, Nov 18, 2019, 3:01 PM Callum Scott ***@***.***> wrote: I’m running 0.10.1 via the official docker image. That fix was in 0.10.0 as far as I can see Sent from my iPhone > On 18 Nov 2019, at 22:38, Luke Kysow ***@***.***> wrote: > > I think this is a duplicate of > #760 > > Can you update Atlantis? > > On Mon, Nov 18, 2019, 9:16 AM Callum Scott ***@***.***> wrote: > > > I am using atlantis 0.10.1 and Gitlab > > When I create an initial merge requests things work as expected and I get > > a merge request with the appropriate changes noted in the output. > > > > If, however, I add a coment for atlantis plan or atlantis apply I get the > > following errors in the logs: > > > > > > > > 2019/11/18 16:24:14+0000 [INFO] middleware.go:38 server: POST /events – from 10.0.0.16:45234 > > > > 2019/11/18 16:24:14+0000 [DBUG] events_controller.go:103 server: Handling GitLab post > > > > 2019/11/18 16:24:14+0000 [WARN] events_controller.go:372 server: Json: cannot unmarshal bool into Go struct field .merge_request.merge_params.force_remove_source_branch of type string > > > > 2019/11/18 16:24:14+0000 [INFO] middleware.go:42 server: POST /events – respond HTTP 400 > > > > > > I have attempted to have a look at the code, however my golang is not > > really existent. > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > < #846?email_source=notifications&email_token=AAH4RPN3LKKUJWS6TXRISO3QULEYLA5CNFSM4JOWXXLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2DJVDA >, > > or unsubscribe > > < https://github.com/notifications/unsubscribe-auth/AAH4RPLS5TXUXRJN4YDREQLQULEYLANCNFSM4JOWXXLA > > > . > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#846?email_source=notifications&email_token=AAH4RPOS4X7JFK37TVLAPZDQUMNF5A5CNFSM4JOWXXLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEMHHBI#issuecomment-555250565>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH4RPLCRZYT53JICBT23ODQUMNF5ANCNFSM4JOWXXLA> .

[Moncky]

For what its worth I have just had a bit of time to build from the current master (c14c9aa) and had the same issue.

[lkysow]

I figured it out, the library missed a spot. I've created xanzy/go-gitlab#740 but need to wait for the library to be updated.