Use regex to filter filenames #1253
Conversation
I ran into an issue where I have a directory of templates I use that I name `foo.tf.template`. I found that Atlantis was running against this directory and failing, which was unexpected behaviour. This is because we're just checking if `.tf` is contained within a filename, rather than checking if it's the suffix of the filename. Instead, we can use regex to ensure that we're only filtering on actual Terraform files, inclusive of `.tf` and `.tfvars` suffixes. There are obviously some alternative ways I could get around this: rename my templates to `foo.template` without the `.tf`. I also really liked the idea of a `.atlantisignore` file previously cited[1], but it was rejected in favour of explicitly defining exactly which directories to run it in. We have a large number of directories so this wasn't appealing to me. I felt this behaviour was sufficiently unexpected that it was worth making a more explicit filter. [1] runatlantis#26
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
=======================================
Coverage 69.98% 69.99%
=======================================
Files 71 71
Lines 5381 5382 +1
=======================================
+ Hits 3766 3767 +1
Misses 1265 1265
Partials 350 350
Continue to review full report at Codecov.
|
|
Thanks @surminus for the improvement. |
|
This seems to ignore *.auto.tfvars.json files for the initial auto-plan feature
Can I somehow change those extensions via server-side config? |
I ran into an issue where I have a directory of templates I use that I name
foo.tf.template. I found that Atlantis was running against this directory and failing, which was unexpected behaviour.This is because we're just checking if
.tfis contained within a filename, rather than checking if it's the suffix of the filename.Instead, we can use regex to ensure that we're only filtering on actual Terraform files, inclusive of
.tfand.tfvarssuffixes.There are obviously some alternative ways I could get around this: rename my templates to
foo.templatewithout the.tf.I also really liked the idea of a
.atlantisignorefile previously cited[1], but it was rejected in favour of explicitly defining exactlywhich directories to run it in. We have a large number of directories so this wasn't appealing to me.
I felt this behaviour was sufficiently unexpected that it was worth making a more explicit filter.
[1] #26