-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete source branch on merge #1357
Delete source branch on merge #1357
Conversation
Hi @nishkrishnan & @lkysow, |
Please review this. This is the only change we need to get back to the official Atlantis instead of having our fork internally. Thanks! |
Hi @acastle, Could you help us to review this branch? We performed the requested refactoring and answered for the open items. |
Hi @nishkrishnan, @lkysow, @acastle, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tapaszto sorry for the delay here. The code changes look good, could you resolve the conflicts in project_command_builder.go and then we can move this forward.
Hi @acastle, |
Hi @nishkrishnan, Do you need anything from us to get this PR merged? |
@nishkrishnan, @acastle, @lkysow Could you guys please take a look ASAP? We would like to merge this finally. Thanks! |
@nishkrishnan, @acastle, @lkysow any update? We needed to merge in updates multiple times by now, we cannot continue this forever. Please review and merge this, it should be up to date now for a merge. |
@nishkrishnan, @acastle, @lkysow, guys, can you approve this PR please? Keeping this branch up-to-date and update it whenever the master is changed is an extreme overhead for us. Our primary goal is using the official community Atlantis releases instead of our own internal fork. Using Atlantis is a strategic decision regarding our Azure IaC deployments within the company |
This is a new feature for Azure DevOps which allows configuring the deletion of the source branch on merge according to the values in the server config and repo config.
Sample server config:
Sample repo config:
delete_source_branch_on_merge is optional in all level, the default value is false if it's not defined in a level
valid values: true | false | not defined