Global atlantis lock new release branch #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding CommandLocker to boltDB and exposing it through locker interface * Apply lock ui and apply command lock controller * Minor comments * Adding more tests and refactorinng * Linting fixes * creating applyLockingClient variable to fix interface error * nullsink for stats * Addressing PR comments * fixing e2e tests * linting fix fml * Update outdated function descriptions Address PR comments * revert stats sink changes
msarvar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1473 +/- ##
==========================================
+ Coverage 69.58% 69.93% +0.35%
==========================================
Files 93 94 +1
Lines 6332 6447 +115
==========================================
+ Hits 4406 4509 +103
- Misses 1549 1558 +9
- Partials 377 380 +3
Continue to review full report at Codecov.
|
|
@nishkrishnan done |
nishkrishnan
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add two additional lock APIs
Both APIs will return an error if
--disable-applyflag is set.There is also a basic UI to lock/unlock apply command. Here are some example screenshots of what it looks like in the atlantis dashboard and PR.
Note: This PR doesn't implement authentication, anyone with an access to atlantis will be able to lock, unlock applies.