-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds allowed_regexp_prefixes
parameter to use with the --enable-regexp-cmd
flag
#1884
feat: adds allowed_regexp_prefixes
parameter to use with the --enable-regexp-cmd
flag
#1884
Conversation
11e3da5
to
5aecc0d
Compare
5aecc0d
to
e4c0b49
Compare
allowed_regexp_prefixes
parameter to use with the --enable-regexp-cmd
flagallowed_regexp_prefixes
parameter to use with the --enable-regexp-cmd
flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
looks like the e2e test job failed, can you take a look at this build? |
thank you @chenrui333! I started to look at the issue but I'm still not able to run the e2e locally. Will spend some time tomorrow to check what might be wrong. |
Sounds good, thanks! |
@chenrui333 I'm really confused with the error since it generated a 403 for https://api.github.com/repos/runatlantis/atlantis-tests/pulls/2867/files?per_page=300 ... that works! could that have been some temporary issue that is now solved? can you retry the tests please? thank you and sorry for the trouble. |
let me re-run the master build. |
Yeah, the master build looks green now. 🎉 (just closed my revert PR) |
Great! I was really puzzled 😅 thank you! |
…ble-regexp-cmd` flag (runatlantis#1884) * adds AllowedRegexpPrefixes config and use it on the FindProjectsByName method * adds tests for the new AllowedRegexpPrefixes config * update documentation with the new AllowedRegexpPrefixes config
Implements what is suggested in #1718.
As explained there, this is useful to be able to execute for example
atlantis apply -p dev/.*
andatlantis apply -p staging/.*
but not any other regex matches, for safety and security reasons.