Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds allowed_regexp_prefixes parameter to use with the --enable-regexp-cmd flag #1884

Conversation

bmbferreira
Copy link
Contributor

Implements what is suggested in #1718.
As explained there, this is useful to be able to execute for example atlantis apply -p dev/.* and atlantis apply -p staging/.* but not any other regex matches, for safety and security reasons.

@bmbferreira bmbferreira requested a review from a team as a code owner November 5, 2021 09:29
@bmbferreira bmbferreira force-pushed the add-allowed_regexp_prefixes-to-config branch from 11e3da5 to 5aecc0d Compare November 5, 2021 09:35
@bmbferreira bmbferreira force-pushed the add-allowed_regexp_prefixes-to-config branch from 5aecc0d to e4c0b49 Compare November 5, 2021 09:41
@chenrui333 chenrui333 changed the title Adds allowed_regexp_prefixes parameter to use with the --enable-regexp-cmd flag feat: adds allowed_regexp_prefixes parameter to use with the --enable-regexp-cmd flag Nov 12, 2021
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrui333 chenrui333 merged commit 79af924 into runatlantis:master Nov 17, 2021
@chenrui333
Copy link
Member

looks like the e2e test job failed, can you take a look at this build?
https://app.circleci.com/pipelines/github/runatlantis/atlantis/1686/workflows/c34a8c00-59b3-43a8-9db4-1989cf405c4f/jobs/8714

@bmbferreira
Copy link
Contributor Author

thank you @chenrui333! I started to look at the issue but I'm still not able to run the e2e locally. Will spend some time tomorrow to check what might be wrong.

@chenrui333
Copy link
Member

Sounds good, thanks!

@bmbferreira
Copy link
Contributor Author

@chenrui333 I'm really confused with the error since it generated a 403 for https://api.github.com/repos/runatlantis/atlantis-tests/pulls/2867/files?per_page=300 ... that works! could that have been some temporary issue that is now solved? can you retry the tests please? thank you and sorry for the trouble.

@chenrui333
Copy link
Member

let me re-run the master build.

@chenrui333
Copy link
Member

chenrui333 commented Nov 18, 2021

Yeah, the master build looks green now. 🎉 (just closed my revert PR)

@bmbferreira
Copy link
Contributor Author

Great! I was really puzzled 😅 thank you!

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…ble-regexp-cmd` flag (runatlantis#1884)

* adds AllowedRegexpPrefixes config and use it on the FindProjectsByName method

* adds tests for the new AllowedRegexpPrefixes config

* update documentation with the new AllowedRegexpPrefixes config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants