-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add clarity and further policy_check examples #1925
docs: add clarity and further policy_check examples #1925
Conversation
fd0b748
to
5f81beb
Compare
5f81beb
to
89b2d84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
steps: | ||
- init | ||
- plan | ||
policy_check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it not be a :
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot
owners: | ||
users: | ||
- example-dev | ||
policy_sets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is indented one too much as it's not a part of the owners object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. I'll put a fix pr together for both.
- plan | ||
policy_check | ||
steps: | ||
- policy_check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lacks a :
?
@oysteingraendsen apologies for the delay. fixed in #1945 👍 |
* Add clarity + further policy_check examples to docs * Fix broken link to Atlantis on AWS Fargate Terraform module Co-authored-by: Dave Heward <74298782+davidh-unmind@users.noreply.github.com>
Resolves #1739