Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use UUIDs to identify log streaming jobs #2051

Merged
merged 8 commits into from
Feb 9, 2022
Merged

feat: Use UUIDs to identify log streaming jobs #2051

merged 8 commits into from
Feb 9, 2022

Conversation

Aayyush
Copy link
Contributor

@Aayyush Aayyush commented Feb 7, 2022 •
edited
Loading

Changes

  • Replaced org/repo/pull/project/workspace with a 32 digit hexadecimal string as job identifier in the log handler and jobs controller
  • Updated the log handler to close the go channel when an operation is complete, which triggers the web socket connection to be closed instead of relying on the user to close the UI tab
  • Add preliminary check before registering new receivers in the log handler
  • Move Job url generation into it's own component to reduce the responsibility on the log handler
  • Move log streaming source files into server/jobs and refactor out log streaming specific models to the jobs package

Using a unique job ID for every operation means our users can now see jobs for each commit. Each of the commit status check links to the logs for that particular revision.

@Aayyush Aayyush requested a review from a team as a code owner February 7, 2022 20:04
@nishkrishnan nishkrishnan changed the title Add UUID for log streaming feat: Use UUIDs to identity log streaming jobs Feb 8, 2022
@nishkrishnan nishkrishnan changed the title feat: Use UUIDs to identity log streaming jobs feat: Use UUIDs to identify log streaming jobs Feb 8, 2022
@nishkrishnan nishkrishnan merged commit 58e9b42 into runatlantis:master Feb 9, 2022
@nishkrishnan nishkrishnan deleted the lyft/logs-uuid branch February 9, 2022 21:15
@ascandella ascandella mentioned this pull request May 17, 2022
Merged
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@Aayyush @krrrr38
feat: Use UUIDs to identify log streaming jobs (runatlantis#2051)
16797bf 
* Add UUID for Log Streaming Job ID (runatlantis#167)

* Update log handler to close buffered  channels when an operation is complete (runatlantis#170)

* Add preliminary check before registering new receivers in the log handler (runatlantis#173)

* Using projectOutputBuffers to check for jobID instead of receiverBuffers (runatlantis#181)

* Refactor log handler  (runatlantis#175)

* Reverting go.mod and go.sum

* Fix lint errors

* Fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishkrishnan nishkrishnan nishkrishnan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aayyush @nishkrishnan