[fix] Ignore commit checks for atlantis apply on Github #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
added
waiting-on-review
|
Fixes #1316 as well, by allowing atlantis:apply check to be required. |
jamengual
approved these changes
Jun 13, 2022
|
Any plans to release this fix? It essentially breaks the main functionality of Atlantis. |
|
we will do a prerelease today
…On Thu., Jun. 16, 2022, 4:09 a.m. Giovanni Tirloni, < ***@***.***> wrote:
Any plans to release this fix? It essentially breaks the main
functionality of Atlantis.
—
Reply to this email directly, view it on GitHub
<#2311 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ3EREVKYNFWPHFMMXHXSLVPMDODANCNFSM5YMGQ5ZA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
prerelease is out, please give it a try
On Thu, Jun 16, 2022 at 9:05 AM Pepe (Jose) Amengual <
***@***.***> wrote:
… we will do a prerelease today
On Thu., Jun. 16, 2022, 4:09 a.m. Giovanni Tirloni, <
***@***.***> wrote:
> Any plans to release this fix? It essentially breaks the main
> functionality of Atlantis.
>
> —
> Reply to this email directly, view it on GitHub
> <#2311 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAQ3EREVKYNFWPHFMMXHXSLVPMDODANCNFSM5YMGQ5ZA>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
|
lilincmu
added a commit
to lilincmu/atlantis
that referenced
this pull request
Jul 13, 2022
…tlantis#2311)" This reverts commit a3db712.
lilincmu
added a commit
that referenced
this pull request
Jul 14, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…2311) * [fix] Ignore commit checks for atlantis apply on Github * Fix typo * Fmt * lint
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…tlantis#2311)" (runatlantis#2388) * Revert "[fix] Ignore commit checks for atlantis apply on Github (runatlantis#2311)" This reverts commit a3db712.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will provide a similar fix for Github as was implemented for Gitlab in #2137. Likely fixes #2310