-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce image size by rm'ing old tf versions #2619
Conversation
@@ -17,7 +17,7 @@ ENV DEFAULT_TERRAFORM_VERSION=1.3.3 | |||
|
|||
# In the official Atlantis image we only have the latest of each Terraform version. | |||
SHELL ["/bin/bash", "-o", "pipefail", "-c"] | |||
RUN AVAILABLE_TERRAFORM_VERSIONS="0.11.15 0.12.31 0.13.7 0.14.11 0.15.5 1.0.11 1.1.9 1.2.9 ${DEFAULT_TERRAFORM_VERSION}" && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking change that we should call out separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we agreed to support only version 1.X to reduce the image size and document the change as a breaking change and announce it in Slack to the community
@nitrocode can we create an issue to track down this removal? I can see there are some code cleanup opportunities as well atlantis/server/core/runtime/plan_step_runner.go Lines 117 to 122 in df94369
|
what
why
references
>=
and~>
specifiers #1776