-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Clone only once per PR #2921
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3ca1fe7
WIP
Fabianoshz 8810cc7
Hooks using default workspace
Fabianoshz e70a1cb
Copy from clean workspace always
Fabianoshz 8f52d09
Revert directory copy logic
Fabianoshz 723605d
Use TF_DATA_DIR
Fabianoshz acd9ace
Adjust tests, remove workspace logic from working.
Fabianoshz d393645
Remove workspace directory logic
Fabianoshz a841022
Adjust tests to use :: as project and workspace separator on planfile
Fabianoshz da91d6c
Fix tfvars and parallel yaml e2e tests
Fabianoshz 078f2e8
Fix tfvars no autoplan e2e test
Fabianoshz 63fa0c2
Merge branch 'main' into clone-only-once
jamengual ac2da5c
Merge branch 'main' into clone-only-once
Fabianoshz 257eefc
Use -reconfigure instead removing dir on e2e tfvars tests
Fabianoshz 60c22f7
Merge branch 'main' into clone-only-once
jamengual ef9b04b
Add DeleteWorkspaceForPath for unlocks
Fabianoshz bf32b63
Merge remote-tracking branch 'upstream/main' into clone-only-once
Fabianoshz 7324b4a
Merge branch 'main' into clone-only-once
Fabianoshz 4c9e04b
Merge branch 'main' into clone-only-once
jamengual be1b5f9
Fix tests for single clone using backend
Fabianoshz 366ad9d
Remove unrelated test
Fabianoshz d585865
Tidy pending_plan_finder
Fabianoshz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 7 additions & 1 deletion
8
...rollers/events/testdata/test-repos/import-single-project/exp-output-apply-no-projects.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,7 @@ | ||
Ran Apply for 0 projects: | ||
Ran Apply for dir: `.` workspace: `default` | ||
|
||
**Apply Error** | ||
``` | ||
no plan found at path "." and workspace "default"–did you run plan? | ||
|
||
``` |
14 changes: 7 additions & 7 deletions
14
server/controllers/events/testdata/test-repos/repo-config-file/exp-output-apply.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
server/controllers/events/testdata/test-repos/workspace-parallel-yaml/exp-output-merge.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
Locks and plans deleted for the projects and workspaces modified in this pull request: | ||
|
||
- dir: `production` workspace: `production` | ||
- dir: `staging` workspace: `staging` | ||
- dir: `.` workspaces: `production`, `staging` |
File renamed without changes.
5 changes: 0 additions & 5 deletions
5
server/controllers/events/testdata/test-repos/workspace-parallel-yaml/staging/main.tf
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before overwriting this env var, can we first check to see if the user supplied it in a custom workflow, and then if it's not set, then we can set it ourselves ?
We should have a test for this too to ensure we get the user provided
TF_DATA_DIR
if one is setexample:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this scenario the user-provided environments override the
TF_DATA_DIR
both onRunCommandAsync
andRunCommandWithVersion
sinceprepCmd
comes before than these on the call stack.