feat: PR check status to show summary e.g. Plan: 1 to add, 0 to change, 1 to destroy #2983
+399
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-status feat: PR check status to show summary e.g. `Plan: 1 to add, 0 to change, 1 to destroy`
krrrr38
commented
Jan 14, 2023
| @@ -34,9 +34,6 @@ type CommitStatusUpdater interface { | |||
| // UpdateCombinedCount updates the combined status to reflect the | |||
| // numSuccess out of numTotal. | |||
| UpdateCombinedCount(repo models.Repo, pull models.PullRequest, status models.CommitStatus, cmdName command.Name, numSuccess int, numTotal int) error | |||
| // UpdateProject sets the commit status for the project represented by | |||
| // ctx. | |||
| UpdateProject(ctx command.ProjectContext, cmdName command.Name, status models.CommitStatus, url string) error | |||
There was a problem hiding this comment.
type StatusUpdater interface has same impl and this is used only for test. so removed.
krrrr38
force-pushed
the
albertorm95-feat-change-plan-status
branch
from
df936b4
to
8355e31
Compare
krrrr38
force-pushed
the
albertorm95-feat-change-plan-status
branch
from
8355e31
to
c778576
Compare
nitrocode
reviewed
Jan 14, 2023
| @@ -48,8 +48,10 @@ type AsyncTFExec interface { | |||
|
|
|||
| // StatusUpdater brings the interface from CommitStatusUpdater into this package | |||
| // without causing circular imports. | |||
| // | |||
| //go:generate pegomock generate -m --package mocks -o mocks/mock_status_updater.go StatusUpdater | |||
| type StatusUpdater interface { | |||
There was a problem hiding this comment.
Are there tests that we can add to runetime_test.go ?
There was a problem hiding this comment.
StatusUpdater is just interface and this impl is DefaultCommitStatusUpdater. This test is implemented in commit_status_updater_test.go, so not needed 👌
StatusUpdater brings the interface from CommitStatusUpdater into this package without causing circular imports.
|
@krrrr38 is this ready to merge? |
yes! |
|
Awesome! Merged :D. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
remain impl for #2699
test
references
Plan: 1 to add, 0 to change, 1 to destroy#2699Plan SucceededshowPlan: 1 to add, 0 to change, 1 to destroy#2625