fix(website): vuepress-next breaking change #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
previously approved these changes
Jul 17, 2023
|
so this was wild all I did was run yarn locally and select 66: atlantis on fix/website-tests [?] via 🐹 v1.19.3 on 🐳 v22.06.0-beta.0-926
➜ yarn
yarn install v1.22.19
[1/4] 🔍 Resolving packages...
warning @vuepress/plugin-google-analytics@2.0.0-beta.50-pre.1: Invalid version. Do not use it
warning vuepress@2.0.0-beta.50-pre.1: Invalid version. Do not use it
Couldnt find any versions for "vuepress-vite" that matches "2.0.0-beta.50-pre.1"
? Please choose a version of "vuepress-vite" from this list:
2.0.0-beta.66
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning "@vuepress/plugin-docsearch > @docsearch/react > @algolia/autocomplete-preset-algolia@1.9.3" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "@vuepress/plugin-docsearch > @docsearch/react > @algolia/autocomplete-core > @algolia/autocomplete-plugin-algolia-insights@1.9.3" has unmet peer dependency "search-insights@>= 1 < 3".
warning "@vuepress/plugin-docsearch > @docsearch/react > @algolia/autocomplete-core > @algolia/autocomplete-shared@1.9.3" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "vuepress > vuepress-vite@2.0.0-beta.66" has unmet peer dependency "vue@^3.3.4".
warning "vuepress > vuepress-vite@2.0.0-beta.66" has unmet peer dependency "@vuepress/client@2.0.0-beta.66".
warning "vuepress > vuepress-vite > @vuepress/theme-default > sass-loader@13.3.2" has unmet peer dependency "webpack@^5.0.0".
[4/4] 🔨 Building fresh packages...
success Saved lockfile.
✨ Done in 11.18s. |
|
that is weird. |
|
Found the issue: vuepress/core#1195 |
GenPage
changed the title
jamengual
previously approved these changes
Jul 18, 2023
jamengual
approved these changes
Jul 18, 2023
auto-merge was automatically disabled
July 24, 2023 23:08
Base branch was modified
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* fix: vuepress-next breaking change See vuepress/core#1195. Other fixes: * fix: website js tests triggering properly * chore: clean up test workflows * fix: yarn packages * fix: renovate config & medium rate limit * fix: don't need to require docker build for JS code * fix: muffet config * fix: properly name website test --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* fix: vuepress-next breaking change See vuepress/core#1195. Other fixes: * fix: website js tests triggering properly * chore: clean up test workflows * fix: yarn packages * fix: renovate config & medium rate limit * fix: don't need to require docker build for JS code * fix: muffet config * fix: properly name website test --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fixes a breaking change introduced by vuepress-next team.
This also moves the website-link-checker into its own workflow and tweaks renovate config.
why
^or~for packages in this repo will fail. vuepress/core#1195.tests
references
closes #3603
closes #3608