-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(atlantis): fix linter errors #3690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
provider/azuredevops
go
Pull requests that update Go code
provider/bitbucket
provider/github
provider/gitlab
labels
Aug 21, 2023
GMartinez-Sisti
force-pushed
the
fix-linters
branch
from
August 21, 2023 10:28
13c54bd
to
e9685c8
Compare
nitrocode
reviewed
Aug 21, 2023
nitrocode
reviewed
Aug 21, 2023
nitrocode
reviewed
Aug 21, 2023
nitrocode
reviewed
Aug 21, 2023
@nitrocode comments addressed. |
Resolved conflict. |
X-Guardian
requested changes
Sep 4, 2023
GenPage
added
bug
Something isn't working
waiting-on-response
Waiting for a response from the user
work-in-progress
and removed
provider/azuredevops
provider/bitbucket
provider/github
provider/gitlab
labels
Sep 11, 2023
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
Merged main again. |
jamengual
added
waiting-on-review
Waiting for a review from a maintainer
and removed
waiting-on-response
Waiting for a response from the user
labels
Nov 15, 2023
All fixed 🥳 Click to expand result.gabrielmartinez @ ~/Git/Misc/atlantis (fix-linters =) → git log -n 1
commit 86fd0e76ad216055bd4498b1b5b74e43895534cc (HEAD -> fix-linters, origin/fix-linters)
Author: Gabriel Martinez <gabrielmartinez@sisti.pt>
Date: Sun Dec 10 12:46:41 2023 +0000
more lint fixes
gabrielmartinez @ ~/Git/Misc/atlantis (fix-linters =) → make lint
golangci-lint run
gabrielmartinez @ ~/Git/Misc/atlantis (fix-linters =) → make test-all
? github.com/runatlantis/atlantis [no test files]
ok github.com/runatlantis/atlantis/cmd 0.635s
ok github.com/runatlantis/atlantis/server 1.292s
ok github.com/runatlantis/atlantis/server/controllers 0.652s
? github.com/runatlantis/atlantis/testdrive [no test files]
ok github.com/runatlantis/atlantis/server/controllers/events 263.081s
ok github.com/runatlantis/atlantis/server/controllers/templates 1.469s
ok github.com/runatlantis/atlantis/server/controllers/websocket 1.109s
ok github.com/runatlantis/atlantis/server/core/config 1.062s
ok github.com/runatlantis/atlantis/server/core/config/raw 0.673s
ok github.com/runatlantis/atlantis/server/core/config/valid 0.402s
ok github.com/runatlantis/atlantis/server/core/db 1.332s
ok github.com/runatlantis/atlantis/server/core/locking 0.498s
ok github.com/runatlantis/atlantis/server/core/redis 0.727s
ok github.com/runatlantis/atlantis/server/core/runtime 3.486s
ok github.com/runatlantis/atlantis/server/core/runtime/cache 0.237s
ok github.com/runatlantis/atlantis/server/core/runtime/common 2.787s
ok github.com/runatlantis/atlantis/server/core/runtime/models 0.464s
ok github.com/runatlantis/atlantis/server/core/runtime/policy 0.424s
ok github.com/runatlantis/atlantis/server/core/terraform 5.867s
ok github.com/runatlantis/atlantis/server/events 25.763s
ok github.com/runatlantis/atlantis/server/events/command 0.331s
ok github.com/runatlantis/atlantis/server/events/models 0.949s
ok github.com/runatlantis/atlantis/server/events/terraform/ansi 0.242s
ok github.com/runatlantis/atlantis/server/events/vcs 9.556s
ok github.com/runatlantis/atlantis/server/events/vcs/bitbucketcloud 0.377s
ok github.com/runatlantis/atlantis/server/events/vcs/bitbucketserver 0.855s
ok github.com/runatlantis/atlantis/server/events/vcs/common 0.269s
ok github.com/runatlantis/atlantis/server/events/webhooks 0.342s
ok github.com/runatlantis/atlantis/server/jobs 0.355s
ok github.com/runatlantis/atlantis/server/logging 0.263s
ok github.com/runatlantis/atlantis/server/metrics 0.292s
ok github.com/runatlantis/atlantis/server/recovery 0.236s
ok github.com/runatlantis/atlantis/server/scheduled 1.261s
ok github.com/runatlantis/atlantis/server/utils 0.434s |
GenPage
approved these changes
Dec 11, 2023
cypres
added a commit
to cypres/atlantis
that referenced
this pull request
Jan 23, 2024
Reverts linter change from runatlantis#3690 which breaks TF v1.1 detection
cypres
added a commit
to cypres/atlantis
that referenced
this pull request
Jan 23, 2024
Reverts linter change from runatlantis#3690 which breaks TF v1.1 detection
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* chore(atlantis): fix linter errors * fix superfluous-else * revert gitlab check * ignore stub funcs on azuredevops_client * remove fetch-depth * remove fail_on_error * fix plan_step_runner_test.go * more lint fixes --------- Co-authored-by: Dylan Page <dylan.page@autodesk.com>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* chore(atlantis): fix linter errors * fix superfluous-else * revert gitlab check * ignore stub funcs on azuredevops_client * remove fetch-depth * remove fail_on_error * fix plan_step_runner_test.go * more lint fixes --------- Co-authored-by: Dylan Page <dylan.page@autodesk.com>
GenPage
pushed a commit
that referenced
this pull request
Mar 5, 2024
Reverts linter change from #3690 which breaks TF v1.1 detection
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
Reverts linter change from #3690 which breaks TF v1.1 detection
GenPage
pushed a commit
that referenced
this pull request
Mar 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
go
Pull requests that update Go code
provider/azuredevops
provider/bitbucket
provider/github
provider/gitlab
waiting-on-review
Waiting for a review from a maintainer
work-in-progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Make the CI lint job fail on error (it's failing silently on all PRs)Removed due to complaintwhy
tests
Tested using
make lint
.Result before PR