Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add use plugin cache flag #3720

Merged
merged 25 commits into from
Sep 22, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e8f0813
feat: Add use plugin cache bool flag
wolmi Aug 31, 2023
8c43159
Merge pull request #1 from wolmi/feature/use_plguin_cache_config_flag
wolmi Aug 31, 2023
828c8ad
Merge branch 'main' into main
wolmi Sep 3, 2023
84430b4
feat: Added use-plugin-cache doc
wolmi Sep 3, 2023
29d2ce0
Merge pull request #2 from wolmi/feature/document_plugin_cache_flag
wolmi Sep 3, 2023
b322ad2
feat: refactor to reflect terrafrom in plugin cache flag
wolmi Sep 4, 2023
b64f22a
Merge branch 'main' into main
wolmi Sep 4, 2023
69f8460
fix: missing closing in bash block documentation
wolmi Sep 4, 2023
3ba343a
fix: typo in flag example
wolmi Sep 4, 2023
3dd93dc
feat: improve docs
wolmi Sep 5, 2023
d35d178
feat: performance implications documented
wolmi Sep 5, 2023
c66001d
Merge branch 'main' into main
wolmi Sep 5, 2023
ae255a5
Merge branch 'main' into main
wolmi Sep 5, 2023
93e7431
Merge branch 'main' into main
wolmi Sep 7, 2023
aaa7fa0
Merge branch 'main' into main
wolmi Sep 7, 2023
d2012d1
Merge branch 'main' into main
wolmi Sep 8, 2023
5160092
Merge branch 'main' into main
wolmi Sep 11, 2023
cab9d74
Merge branch 'main' into main
wolmi Sep 11, 2023
26b62ae
Merge branch 'main' into main
wolmi Sep 11, 2023
5e4c7b2
Merge branch 'main' into main
wolmi Sep 12, 2023
e743594
Merge branch 'main' into main
wolmi Sep 13, 2023
e732bcd
Merge remote-tracking branch 'upstream/main'
wolmi Sep 14, 2023
d814e94
feat: increase terraform minor version to 1.3.10
wolmi Sep 14, 2023
c3ef974
Merge branch 'main' into main
wolmi Sep 18, 2023
ff09b3b
Merge branch 'main' into main
wolmi Sep 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ const (
RestrictFileList = "restrict-file-list"
TFDownloadFlag = "tf-download"
TFDownloadURLFlag = "tf-download-url"
UsePluginCache = "use-plugin-cache"
wolmi marked this conversation as resolved.
Show resolved Hide resolved
VarFileAllowlistFlag = "var-file-allowlist"
VCSStatusName = "vcs-status-name"
TFEHostnameFlag = "tfe-hostname"
Expand Down Expand Up @@ -558,6 +559,10 @@ var boolFlags = map[string]boolFlag{
description: "Remove no-changes plan comments from the pull request.",
defaultValue: false,
},
UsePluginCache: {
description: "Enable the use of plugin cache",
defaultValue: true,
},
wolmi marked this conversation as resolved.
Show resolved Hide resolved
}
var intFlags = map[string]intFlag{
CheckoutDepthFlag: {
Expand Down
2 changes: 1 addition & 1 deletion server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ func NewServer(userConfig UserConfig, config Config) (*Server, error) {
userConfig.TFDownloadURL,
&terraform.DefaultDownloader{},
userConfig.TFDownload,
true,
userConfig.UsePluginCache,
wolmi marked this conversation as resolved.
Show resolved Hide resolved
projectCmdOutputHandler)
// The flag.Lookup call is to detect if we're running in a unit test. If we
// are, then we don't error out because we don't have/want terraform
Expand Down
1 change: 1 addition & 0 deletions server/user_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ type UserConfig struct {
WebPassword string `mapstructure:"web-password"`
WriteGitCreds bool `mapstructure:"write-git-creds"`
WebsocketCheckOrigin bool `mapstructure:"websocket-check-origin"`
UsePluginCache bool `mapstructure:"use-plugin-cache"`
wolmi marked this conversation as resolved.
Show resolved Hide resolved
}

// ToAllowCommandNames parse AllowCommands into a slice of CommandName
Expand Down