-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove deprecated repo whitelist flag #3922
Merged
jamengual
merged 1 commit into
runatlantis:main
from
lukemassa:remove_deprecated_repo_whitelist_flag
Nov 14, 2023
Merged
feat: Remove deprecated repo whitelist flag #3922
jamengual
merged 1 commit into
runatlantis:main
from
lukemassa:remove_deprecated_repo_whitelist_flag
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
changed the title
Remove deprecated repo whitelist flag
feat: remove deprecated repo whitelist flag
Nov 5, 2023
lukemassa
changed the title
feat: remove deprecated repo whitelist flag
feat: Remove deprecated repo whitelist flag
Nov 5, 2023
nitrocode
previously approved these changes
Nov 5, 2023
jamengual
previously approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lukemassa for the contribution
lukemassa
force-pushed
the
remove_deprecated_repo_whitelist_flag
branch
from
November 14, 2023 05:46
d22f58c
to
bfa7221
Compare
@jamengual I had to resolve some conflicts introduced by #3923 being merged before this change, not sure how this affects the cherry-pick stuff |
/cherry-pick release-0.26 |
jamengual
approved these changes
Nov 14, 2023
Thanks @lukemassa |
GenPage
added
feature
New functionality/enhancement
refactoring
Code refactoring that doesn't add additional functionality
breaking-change
labels
Dec 12, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
feature
New functionality/enhancement
go
Pull requests that update Go code
refactoring
Code refactoring that doesn't add additional functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Remove
--repo-whitelist
flag.why
This flag was deprecated in 8ac19e4
tests
This setting only appeared in configuration, and any behavior changes had been deferred to
--repo-allowlist
, so unit tests passing should be sufficient.The only functional change of this PR is then:
references