Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove deprecated repo whitelist flag #3922

Merged

Conversation

lukemassa
Copy link
Contributor

@lukemassa lukemassa commented Nov 5, 2023

what

Remove --repo-whitelist flag.

why

This flag was deprecated in 8ac19e4

tests

This setting only appeared in configuration, and any behavior changes had been deferred to --repo-allowlist, so unit tests passing should be sufficient.

The only functional change of this PR is then:

Error: unknown flag: --repo-whitelist

references

@lukemassa lukemassa requested a review from a team as a code owner November 5, 2023 18:23
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 5, 2023
@lukemassa lukemassa changed the title Remove deprecated repo whitelist flag feat: remove deprecated repo whitelist flag Nov 5, 2023
@lukemassa lukemassa changed the title feat: remove deprecated repo whitelist flag feat: Remove deprecated repo whitelist flag Nov 5, 2023
nitrocode
nitrocode previously approved these changes Nov 5, 2023
jamengual
jamengual previously approved these changes Nov 5, 2023
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukemassa for the contribution

@lukemassa lukemassa dismissed stale reviews from nitrocode and jamengual via bfa7221 November 14, 2023 05:46
@lukemassa lukemassa force-pushed the remove_deprecated_repo_whitelist_flag branch from d22f58c to bfa7221 Compare November 14, 2023 05:46
@lukemassa
Copy link
Contributor Author

@jamengual I had to resolve some conflicts introduced by #3923 being merged before this change, not sure how this affects the cherry-pick stuff

@jamengual
Copy link
Contributor

/cherry-pick release-0.26

@jamengual
Copy link
Contributor

Thanks @lukemassa

@jamengual jamengual merged commit 99035ce into runatlantis:main Nov 14, 2023
24 checks passed
@GenPage GenPage added feature New functionality/enhancement refactoring Code refactoring that doesn't add additional functionality breaking-change labels Dec 12, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change feature New functionality/enhancement go Pull requests that update Go code refactoring Code refactoring that doesn't add additional functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants