Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Document for server-side-repo-config.md #4052

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

champs
Copy link
Contributor

@champs champs commented Dec 13, 2023

Update document for Metric on repo config

what

Document failed to describe metrics at the root level metric of repo configuration

why

Because it's incorrect and misleading
https://github.com/runatlantis/atlantis/blob/main/server/core/config/raw/global_cfg.go#L18

tests

NA

references

https://github.com/runatlantis/atlantis/blob/main/server/core/config/raw/global_cfg.go#L18

Update document for Metric on repo config
@champs champs requested a review from a team as a code owner December 13, 2023 21:13
@github-actions github-actions bot added the docs Documentation label Dec 13, 2023
@champs champs changed the title Update Document for server-side-repo-config.md docs: Update Document for server-side-repo-config.md Dec 13, 2023
@lukemassa lukemassa self-assigned this Dec 20, 2023
Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>
@champs champs requested a review from a team as a code owner December 26, 2023 16:58
@champs champs requested review from X-Guardian and removed request for a team December 26, 2023 16:58
@lukemassa lukemassa merged commit 6452a3c into runatlantis:main Dec 27, 2023
23 checks passed
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* Update server-side-repo-config.md

Update document for Metric on repo config

* docs(server-side-repo-config): fix case

Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>

---------

Co-authored-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* Update server-side-repo-config.md

Update document for Metric on repo config

* docs(server-side-repo-config): fix case

Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>

---------

Co-authored-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants