-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unnamed jobs in ui, remove uppercasing #4137
Conversation
2f29a0c
to
fe641a9
Compare
Any idea why netlify initialization fails ? |
It looks like this was updated by: #4136. I will update |
fe641a9
to
1599ad7
Compare
@tlorreyte I rebased the PR which fixed the issue. Originally I had thought #4136 had caused the issue, but now I think it was just some transient failure |
Thank you for the fix. Regarding the empty project and workspace, if the values are empty, can we remove the empty code formatting that's left there? |
@nitrocode sure, that should be possible |
1599ad7
to
be6dd5f
Compare
be6dd5f
to
b283781
Compare
@nitrocode I've just added an if condition on empty strings, it should be enough : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @GenPage @jamengual
Nice job! Thank you all. |
/cherry-pick release-0.27 |
what
why
As correctly described in #4132, the jobs were not clearly identifiable on the home page.
Several fields have been added to the output structure of the various jobs to enable them to be displayed.
On the PR, with a repos yaml like this :
the page looks like this :
Unfortunately, the project and workspace fields will remain empty due to the differences between a job and hook context.
tests
The templating test has been enhanced with jobToMapping data.
references