build: fix build terraform/opentofu build pathing

[dylanhitt]

what

Fixes pathing when copying opentofu/terraform bins to release image

It seems in the deps container it symlinks to /tmp/build/{tofu,terraform}${version}. Not sure if that was intended and the COPY from deps was just forgotten 🤷. Let me know the intention and I can edit the PR.

Thanks

why

In the current on dev image the terraform bins do not exist:

➜  ~ docker run -it ghcr.io/runatlantis/atlantis:dev-debian bash
No files found in /docker-entrypoint.d/, skipping
atlantis@616313fed2f9:/$ terraform -v
bash: terraform: command not found
atlantis@616313fed2f9:/$ find -name terraform
find: './etc/ssl/private': Permission denied
find: './proc/tty/driver': Permission denied
find: './var/cache/ldconfig': Permission denied
find: './var/cache/apt/archives/partial': Permission denied
find: './root': Permission denied
atlantis@616313fed2f9:/$

vs previous

➜  ~ docker run -it ghcr.io/runatlantis/atlantis:latest bash
No files found in /docker-entrypoint.d/, skipping
a2c9ab7d1aee:/$ which terraform
/usr/local/bin/terraform
a2c9ab7d1aee:/$ find -name terraform
find: ./proc/tty/driver: Permission denied
./usr/local/bin/terraform
find: ./root: Permission denied
a2c9ab7d1aee:/$

tests

• I have tested my changes by building locally validating the dirs/executabls

➜  atlantis git:(fix/build) ✗ docker run --rm -it --entrypoint bash hello:hello -c "ls -la /usr/local/bin/tofu* && which tofu && tofu -v"
-rwxr-xr-x 1 root root 75497472 Feb 22 12:14 /usr/local/bin/tofu
-rwxr-xr-x 1 root root 75497472 Feb 22 12:14 /usr/local/bin/tofu1.6.2
/usr/local/bin/tofu
OpenTofu v1.6.2
on linux_arm64
➜  atlantis git:(fix/build) ✗ docker run --rm -it --entrypoint bash hello:hello -c "ls -la /usr/local/bin/tofu* && which tofu && tofu -v"
-rwxr-xr-x 1 root root 75497472 Feb 22 12:14 /usr/local/bin/tofu
-rwxr-xr-x 1 root root 75497472 Feb 22 12:14 /usr/local/bin/tofu1.6.2
/usr/local/bin/tofu
OpenTofu v1.6.2
on linux_arm64

references

• Preinstall opentofu in containers #4337
• Previous PR feat: add v1.6.2 opentofu binary to container #4341

[jamengual]

@nitrocode you recently worked on this, do you have any comments?

[nitrocode]

lgtm

[nitrocode]

Thanks for the contribution and the quick fix. I approved it earlier and forgot to merge