fix: GitHub tests emitting unexpected keepers = {} #4462
Conversation
Version v3.6.1 of the 'random' provider changed the behavior of 'keeper' in hashicorp/terraform-provider-random#385 This upstream change caused the extra keepers = {} output in our test output since keepers are optional, and {} is same as absent for our use-cases, we're removing the empty keepers = {} from the .tf files
jippi
requested review from
GenPage,
lukemassa and
X-Guardian
and removed request for
a team
| @@ -1,4 +1,3 @@ | |||
| resource "random_id" "dummy1" { | |||
There was a problem hiding this comment.
Since this issue came from a provider version update, to keep the tests deterministic, what do you think of pinning the provider versions for each of these terraform random provider (and possibly other provider) tests?
We can add it to main.tf or add a new versions.tf like upstream modules do it.
| resource "random_id" "dummy1" { | |
| provider "random" {} | |
| terraform { | |
| required_providers { | |
| random = { | |
| source = "hashicorp/random" | |
| version = "= 3.6.1" | |
| } | |
| } | |
| } | |
| resource "random_id" "dummy1" { |
There was a problem hiding this comment.
I agree we should probably pin this, or at least worth a discussion. I'm fine making that a followup and merging this as-is, since unit tests being broken on main is causing downstream issues.
| @@ -1,4 +1,3 @@ | |||
| resource "random_id" "dummy2" { | |||
There was a problem hiding this comment.
Related https://github.com/runatlantis/atlantis/pull/4462/files#r1573148934
| resource "random_id" "dummy2" { | |
| terraform { | |
| required_providers { | |
| random = { | |
| source = "hashicorp/random" | |
| version = "= 3.6.1" | |
| } | |
| } | |
| } | |
| resource "random_id" "dummy2" { |
| declare -r output | ||
|
|
||
| if [[ -n "$output" ]]; then | ||
| echo "These files had their 'import' changed - please fix them locally and push a fix" |
There was a problem hiding this comment.
In the future, we may be able to automate this via pre-commit-config
|
thanks @jippi for the contribution |
|
/cherry-pick release-0.27 |
Co-authored-by: Christian Winther <jippignu@gmail.com>
what
Version v3.6.1 of the
randomprovider changed the behavior ofkeepersin hashicorp/terraform-provider-random#385This upstream change caused the extra
keepers = {}output in our test output due to how thevalueofkeepersinside the provider is processed.Since
keepersare optional in the provider and{}is same asabsent(ornull) for our use-cases, I'm removing the emptykeepers = {}from the.tffilesI also fixed
make check-fmtsince it was failing silently withgoimportsnot being installed in CI.why
I like tests passing
tests
All changes are test related - and pure output focused - shouldn't affect any actual behavior
references