-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added a space line #4787
fix: added a space line #4787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dorian-tsorfy
This PR is causing tests to fail in the main branch. Example: https://github.com/runatlantis/atlantis/actions/runs/10209313703/job/28247149152?pr=4804
This file needs updating |
This reverts commit dac9141.
@dorian-tsorfy, this PR has been reverted as it was causing the Test CI to fail. Can you raise another PR with this change plus the updates needed to the server/events/markdown_renderer_test.go file. Thanks! |
what
I added a space line to the
policy_check_results_wrapped.tmpl
file so the output on GitLab will look nice.Resolving issue #4623.
why
We have noticed intermittent issues rendering the markdown Atlantis outputs to GitLab when a policy check failure occurs ever since upgrading from v0.27.3 to v0.28.1. I suspect this could be related to #4254 and the formatting changes it made.
tests
references
#4623