Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link latest commit to the correct pipeline #4865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rgs1
Copy link

@rgs1 rgs1 commented Aug 21, 2024

PR #4785 was a partial fix, as it might link a commit to the wrong pipeline when GitLab is slow to update the HeadPipeline.

This patch ensures the latest commit is always linked to the correct pipeline by querying the pipeline associated with the commit's ref, instead of relying on HeadPipeline.

Tested in our environment and it looks good so far.

Signed-off-by: Raul Gutierrez Segales rsegales@nvidia.com

PR runatlantis#4785 was a partial fix, as it might link a commit to the wrong pipeline when
GitLab is slow to update the HeadPipeline.

This patch ensures the latest commit is always linked to the correct
pipeline by querying the pipeline associated with the commit's ref,
instead of relying on HeadPipeline.

Tested in our environment and it looks good so far.

Signed-off-by: Raul Gutierrez Segales <rsegales@nvidia.com>
@rgs1 rgs1 requested review from a team as code owners August 21, 2024 18:52
@rgs1 rgs1 requested review from jamengual, nitrocode and X-Guardian and removed request for a team August 21, 2024 18:52
@github-actions github-actions bot added go Pull requests that update Go code provider/gitlab labels Aug 21, 2024
@rgs1 rgs1 changed the title gitlab: link latest commit to the correct pipeline fix(gitlab) link latest commit to the correct pipeline Aug 21, 2024
@rgs1 rgs1 changed the title fix(gitlab) link latest commit to the correct pipeline fix: link latest commit to the correct pipeline Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code provider/gitlab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant