Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: perm removal from testing-env-image #4955

Merged
merged 1 commit into from
Sep 26, 2024
Merged

ci: perm removal from testing-env-image #4955

merged 1 commit into from
Sep 26, 2024

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Sep 26, 2024 •
edited
Loading

what

  • perm removal from testing-env-image

why

  • Due to the action pushing an image on merge which failed cause of the read perms
  • The atlantis-image action isn't affected

tests

references

@nitrocode nitrocode requested review from a team as code owners September 26, 2024 17:19
@nitrocode nitrocode requested review from GenPage, lukemassa and X-Guardian and removed request for a team September 26, 2024 17:19
@nitrocode nitrocode enabled auto-merge (squash) September 26, 2024 17:19
@nitrocode nitrocode requested a review from jamengual September 26, 2024 17:21
@nitrocode nitrocode merged commit e14240f into main Sep 26, 2024
32 of 34 checks passed
@nitrocode nitrocode deleted the perm-removal-from-testing-env-image branch September 26, 2024 17:29
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
a1k0u pushed a commit to a1k0u/atlantis that referenced this pull request Nov 1, 2024
@nitrocode @a1k0u
ci: perm removal from testing-env-image (runatlantis#4955)
10fd945 
Signed-off-by: a1k0u <alko7enko@gmail.com>
terakoya76 pushed a commit to terakoya76/atlantis that referenced this pull request Dec 31, 2024
@nitrocode @terakoya76
ci: perm removal from testing-env-image (runatlantis#4955)
fb9af7c
kvanzuijlen pushed a commit to kvanzuijlen/atlantis that referenced this pull request Jan 4, 2025
@nitrocode @kvanzuijlen
ci: perm removal from testing-env-image (runatlantis#4955)
e1879ea 
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@GenPage GenPage Awaiting requested review from GenPage GenPage is a code owner automatically assigned from runatlantis/maintainers

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
github-actions lgtm This PR has been approved by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual