feat: add http webhook #5233
Open
feat: add http webhook #5233
+576
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zendesk-piotrpawluk
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
github-actions
bot
added
docs
zendesk-piotrpawluk
force-pushed
the
http-webhook
branch
from
bbb3a44 to
d6774bf
Compare
Signed-off-by: Piotr Pawluk <piotr.pawluk@zendesk.com>
zendesk-piotrpawluk
force-pushed
the
http-webhook
branch
from
24cf799 to
9bd4c5d
Compare
|
Rebased |
1 task
lukemassa
approved these changes
Jan 20, 2025
| } | ||
|
|
||
| // RoundTrip handles each http request. | ||
| func (t *AuthedTransport) RoundTrip(req *http.Request) (*http.Response, error) { |
There was a problem hiding this comment.
https://pkg.go.dev/net/http#RoundTripper says
RoundTrip should not modify the request, except for consuming and closing the Request's Body
I'm not very familiar with the http package, so I'm not sure what the implications are if the request is modified (or if adding headers qualifies as "modifying"), any thoughts here?
As an alternative you could always pass the headers into the webhook itself then set them on doSend()
| return nil | ||
| } | ||
|
|
||
| func (h *HttpWebhook) doSend(_ logging.SimpleLogging, applyResult ApplyResult) error { |
There was a problem hiding this comment.
Since doSend() is a non-exported method (i.e. unlike Send()) you should be able to omit logging.SimpleLogging altogether instead of passing it in and not using it.
(Though this does mean you'll have to make logging.SimpleLogging _ in Send())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adding HTTP webhook implementation to send notifications to any HTTP(S) endpoint.
httpwebhook kind--webhook-http-headersoptional parameter to pass any extra headers with the requestProjectNameto webhook payloadwhy
To send notifications to other systems than just Slack. Feature request: #810
tests
references