Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dockerfile terraform version to 0.11.14 #641

Closed
wants to merge 1 commit into from

Conversation

tonejito
Copy link

Terraform was v0.11.13, might require a rebuild of the official docker image and push to DockerHub

Terraform was v0.11.13, might require a rebuild of the official
docker image and push to DockerHub
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files          61       61           
  Lines        4633     4633           
=======================================
  Hits         3344     3344           
  Misses       1044     1044           
  Partials      245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 756bf18...419d112. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files          61       61           
  Lines        4633     4633           
=======================================
  Hits         3344     3344           
  Misses       1044     1044           
  Partials      245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 756bf18...419d112. Read the comment docs.

@lkysow
Copy link
Member

lkysow commented May 23, 2019

Thanks for the PR! Since 0.12 is out though, I'm going to upgrade to that.
You can still use 0.11.14 though, just set the --default-tf-version=0.11.14 flag.

@lkysow lkysow closed this May 23, 2019
@pratikmallya
Copy link
Contributor

@lkysow I'm sure you are aware of it, but updating atlantis to use 0.12 might break a lot of folks' state files... do you think 0.12 could be enabled optionally instead of by default? Or is the plan to just update to 0.12 and ask users to not upgrade atlantis until they migrate all their terraform configs to 0.12?

@lkysow
Copy link
Member

lkysow commented May 23, 2019

@pratikmallya users just need to set --default-tf-version to whatever version they need and it won't break anything.

@tonejito
Copy link
Author

Can we at least put the 0.11.14 version in the list of AVAILABLE_TERRAFORM_VERSIONS on the Dockerfile?. I made exactly this on a custom Dockerfile and it certainly worked.

It makes sense to keep 0.11.14 because atlantis aim to keep the latest release of each terraform version and #645 just removed 0.11.13:

# In the official Atlantis image we only have the latest of each Terrafrom version.
RUN AVAILABLE_TERRAFORM_VERSIONS="0.8.8 0.9.11 0.10.8 0.11.14 ${DEFAULT_TERRAFORM_VERSION}" && \

@lkysow
Copy link
Member

lkysow commented May 23, 2019

@tonejito yes that makes sense!

@lkysow
Copy link
Member

lkysow commented May 23, 2019

Also you're right, that was a mistake on my part, thanks 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants