-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Dockerfile terraform version to 0.11.14 #641
Conversation
Terraform was v0.11.13, might require a rebuild of the official docker image and push to DockerHub
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
=======================================
Coverage 72.17% 72.17%
=======================================
Files 61 61
Lines 4633 4633
=======================================
Hits 3344 3344
Misses 1044 1044
Partials 245 245 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
=======================================
Coverage 72.17% 72.17%
=======================================
Files 61 61
Lines 4633 4633
=======================================
Hits 3344 3344
Misses 1044 1044
Partials 245 245 Continue to review full report at Codecov.
|
Thanks for the PR! Since 0.12 is out though, I'm going to upgrade to that. |
@lkysow I'm sure you are aware of it, but updating atlantis to use 0.12 might break a lot of folks' state files... do you think 0.12 could be enabled optionally instead of by default? Or is the plan to just update to 0.12 and ask users to not upgrade atlantis until they migrate all their terraform configs to 0.12? |
@pratikmallya users just need to set |
Can we at least put the 0.11.14 version in the list of It makes sense to keep 0.11.14 because # In the official Atlantis image we only have the latest of each Terrafrom version.
RUN AVAILABLE_TERRAFORM_VERSIONS="0.8.8 0.9.11 0.10.8 0.11.14 ${DEFAULT_TERRAFORM_VERSION}" && \ |
@tonejito yes that makes sense! |
Also you're right, that was a mistake on my part, thanks 🍺 |
Terraform was v0.11.13, might require a rebuild of the official docker image and push to DockerHub