Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split GitHub comments into multiple if over max. #66

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 14, 2018

Fixes #55. GitHub will throw an error if the comment is over
65535 characters. Now we will split up a comment into multiple
comments if it's over that size.

Fixes #55. GitHub will throw an error if the comment is over
65535 characters. Now we will split up a comment into multiple
comments if it's over that size.
@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #66 into master will increase coverage by 0.19%.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage    63.9%   64.09%   +0.19%     
==========================================
  Files          40       40              
  Lines        1892     1916      +24     
==========================================
+ Hits         1209     1228      +19     
- Misses        621      626       +5     
  Partials       62       62
Impacted Files Coverage Δ
server/server.go 70.08% <100%> (ø) ⬆️
server/events/vcs/github_client.go 22.09% <73.07%> (+22.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792df5c...b7e58e2. Read the comment docs.

@lkysow lkysow merged commit 28a9a1b into master Mar 14, 2018
@lkysow lkysow deleted the comment-size branch March 14, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant