Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when redefining default workflow #862

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Fix bug when redefining default workflow #862

merged 1 commit into from
Nov 27, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 27, 2019

Previously, given the config:

  workflows:
    default:
      ...

We wouldn't actually use the redefined default workfow in our always
existing first repo config. This would mean that the redefined default
was never used unless users explicitly set workflow: default in the
repos array.

Fixes #860

Previously, given the config:
  workflows:
    default:
      ...

We wouldn't actually use the redefined default workfow in our always
existing first repo config. This would mean that the redefined default
was never used unless users explicitly set workflow: default in the
repos array.
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #862 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
- Coverage   71.83%   71.79%   -0.05%     
==========================================
  Files          65       65              
  Lines        5213     5216       +3     
==========================================
  Hits         3745     3745              
- Misses       1183     1186       +3     
  Partials      285      285
Impacted Files Coverage Δ
server/events/yaml/raw/global_cfg.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634392d...153ac96. Read the comment docs.

@lkysow lkysow merged commit e09ee55 into master Nov 27, 2019
@lkysow lkysow deleted the fix-default branch November 27, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting the default workflow in server side yaml does not work.
1 participant