-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Git LFS support #872
Add Git LFS support #872
Conversation
@lkysow I made some tests and this seems to work, I've some trouble to write a unit test for it though as Git LFS expect having an HTTP server to read the file from and does not support the |
Codecov Report
@@ Coverage Diff @@
## master #872 +/- ##
=======================================
Coverage 71.87% 71.87%
=======================================
Files 65 65
Lines 5244 5244
=======================================
Hits 3769 3769
Misses 1188 1188
Partials 287 287 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested a git lfs repo on an Atlantis Docker image where git-lfs
is installed and git lfs install
was run and everything works fine. Why do we need the additional git lfs pull
command?
Just checked and it seems that recent packages install |
Yes please. Also test that git lfs install isn't necessary. If it is, it needs to be run on the Docker image. |
I tried on alpine, Debian and Centos and it seems to run on install now. It seems to be like this for Debian since 2016 (https://github.com/git-lfs/git-lfs/blob/master/debian/postinst). |
Thanks for creating the PR @remilapeyre. Do we require any additional testing? My environment depends on LFS making this a really nice addition to Atlantis for us. |
This Is great, we depend on this change too, would be nice to get it merged 💯 |
Sorry for the delay here. |
Closes #869