Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File upload is now adjusted to use the progress events from
HttpClient
in@angular/common/http
.Also the progress events don't fire when using a serviceworker, so commit 16b4b9d is about bypassing the service worker for the file upload URL.
The problem is mentioned in the following Angular issues:
angular/angular#21191
angular/angular#24683
Hopefully just letting the fetch event handler return instead of calling
event.respondWith()
could be supported for selected patterns/URLs in future Angular versions. See the exact patch ofngsw-worker.js
here:runbox7/ngsw-worker-patched.js
Line 1941 in 16b4b9d
(currently this file is just copied into the
dist
folder after build so it needs to be updated if there are new versions of@angular/service-worker
)