Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker): Add sentry to xapian worker scope #1618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shadowbas
Copy link
Contributor

@shadowbas shadowbas commented Nov 13, 2024

Add sentry to the Xapian worker.

  • Rebase

Related: #1617

@shadowbas shadowbas requested a review from castaway November 13, 2024 12:21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@castaway , this approach of code gen and using git to revert is very messy and was causing me issues. I suggest we have this one env file that is generated using the ./gen-env.js script. We use this module instead of interpolating writing and reverting with git.

.eslintrc.json Outdated Show resolved Hide resolved
@shadowbas shadowbas force-pushed the shadowbas/feat-worker-add-sentry-toxapian-worker-scope branch 2 times, most recently from 8f4a926 to fae7ce7 Compare November 14, 2024 13:01
@shadowbas shadowbas force-pushed the shadowbas/feat-worker-add-sentry-toxapian-worker-scope branch from fae7ce7 to 2674e2a Compare November 14, 2024 14:18
import * as Sentry from '@sentry/browser';

Sentry.init({
dsn: environment.SENTRY_DSN
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add to capture console.error messages:

  integrations: [Sentry.captureConsoleIntegration()],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant