Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Fix: small issues #44

Merged
merged 6 commits into from
Jun 25, 2022
Merged

Fix: small issues #44

merged 6 commits into from
Jun 25, 2022

Conversation

pwltr
Copy link
Contributor

@pwltr pwltr commented Jun 19, 2022 •
edited
Loading

  • use hostname from env var for development, fallback in vite config
  • fix sdk import syntax
  • use fast polling in development
  • fix: some types
  • Fix sidebar "jumping" when navigating to AppStore
    Screenshot_20220615_141710

AaronDewes
AaronDewes previously approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@AaronDewes AaronDewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflicts

@pwltr
Copy link
Contributor Author

pwltr commented Jun 19, 2022

This is still a draft for now. I'll add some more bug fixes and then rebase everything.

@pwltr
Copy link
Contributor Author

pwltr commented Jun 24, 2022

You can review this now. I tried to get a fix in for the FeeSelector and @vue/compat bugs but no dice...

@pwltr pwltr marked this pull request as ready for review June 24, 2022 07:29
AaronDewes
AaronDewes approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@AaronDewes AaronDewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I'm working on something better to solve the Vue issues anyway

@WilliamConnatser WilliamConnatser merged commit a0a5fc7 into main Jun 25, 2022
@pwltr pwltr deleted the fix/small-issues branch June 25, 2022 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronDewes AaronDewes AaronDewes approved these changes

@WilliamConnatser WilliamConnatser WilliamConnatser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwltr @WilliamConnatser @AaronDewes