item on npc, and abusing sheep #111
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { incomingPacket } from '../incoming-packet'; | ||
| import { Player } from '../../world/actor/player/player'; | ||
| import { RsBuffer } from '@server/net/rs-buffer'; | ||
| import { widgets } from '@server/world/config/widget'; | ||
| import { logger } from '@runejs/logger/dist/logger'; | ||
| import { itemOnItemAction } from '@server/world/actor/player/action/item-on-item-action'; | ||
| import { Position } from '@server/world/position'; | ||
| import { gameCache, world } from '@server/game-server'; | ||
| import { objectAction } from '@server/world/actor/player/action/object-action'; | ||
| import { itemOnObjectAction } from '@server/world/actor/player/action/item-on-object-action'; | ||
| import { World } from '@server/world/world'; | ||
| import { npcAction } from '@server/world/actor/player/action/npc-action'; | ||
| import { itemOnNpcAction } from '@server/world/actor/player/action/item-on-npc-action'; | ||
|
|
||
| export const itemOnNpcPacket: incomingPacket = (player: Player, packetId: number, packetSize: number, packet: RsBuffer): void => { | ||
| const npcIndex = packet.readNegativeOffsetShortBE(); | ||
| const itemId = packet.readNegativeOffsetShortBE(); | ||
| const itemSlot = packet.readNegativeOffsetShortLE(); | ||
| const itemWidgetId = packet.readShortBE(); | ||
| const itemContainerId = packet.readShortBE(); | ||
|
|
||
| let usedItem; | ||
| if (itemWidgetId === widgets.inventory.widgetId && itemContainerId === widgets.inventory.containerId) { | ||
| if (itemSlot < 0 || itemSlot > 27) { | ||
| return; | ||
| } | ||
|
|
||
| usedItem = player.inventory.items[itemSlot]; | ||
| if (!usedItem) { | ||
| return; | ||
| } | ||
|
|
||
| if (usedItem.itemId !== itemId) { | ||
| return; | ||
| } | ||
| } else { | ||
| logger.warn(`Unhandled item on object case using widget ${itemWidgetId}:${itemContainerId}`); | ||
| } | ||
|
|
||
|
|
||
| if (npcIndex < 0 || npcIndex > World.MAX_NPCS - 1) { | ||
| return; | ||
| } | ||
|
|
||
| const npc = world.npcList[npcIndex]; | ||
| if (!npc) { | ||
| return; | ||
| } | ||
|
|
||
| const position = npc.position; | ||
| const distance = Math.floor(position.distanceBetween(player.position)); | ||
|
|
||
| // Too far away | ||
| if (distance > 16) { | ||
| return; | ||
| } | ||
|
|
||
| itemOnNpcAction(player, npc, position, usedItem, itemWidgetId, itemContainerId); | ||
|
|
||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { World } from '@server/world/world'; | ||
| import { ActionType, RunePlugin } from '@server/plugins/plugin'; | ||
| import { itemIds } from '@server/world/config/item-ids'; | ||
| import { itemOnObjectAction } from '@server/world/actor/player/action/item-on-object-action'; | ||
| import { itemOnNpcAction } from '@server/world/actor/player/action/item-on-npc-action'; | ||
|
|
||
|
|
||
| export const action: itemOnNpcAction = (details) => { | ||
| details.player.busy = true; | ||
| details.player.playAnimation(893); | ||
| details.player.outgoingPackets.playSound(761, 5); | ||
|
|
||
|
|
||
| setTimeout(() => { | ||
| if (Math.random() >= 0.66) { | ||
| details.player.outgoingPackets.chatboxMessage('The sheep manages to get away from you!'); | ||
| // TODO: sheep says baa!, makes baa sound and goes backwards about 5 tiles | ||
| } else { | ||
| details.player.outgoingPackets.chatboxMessage('You get some wool.'); | ||
| details.player.giveItem(1737); | ||
|
|
||
| // TODO: sheep says baa!, makes baa sound and gets replaces with skinned sheep | ||
|
|
||
| } | ||
| details.player.busy = false; | ||
| }, World.TICK_LENGTH); | ||
|
|
||
| }; | ||
|
|
||
| export default new RunePlugin({ | ||
| type: ActionType.ITEM_ON_NPC_ACTION, | ||
| npcsIds: [43], | ||
| itemIds: [1735, 5603], | ||
|
|
||
| walkTo: true, | ||
| action | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| import { Player } from '@server/world/actor/player/player'; | ||
| import { Position } from '@server/world/position'; | ||
| import { walkToAction } from '@server/world/actor/player/action/action'; | ||
| import { pluginFilter } from '@server/plugins/plugin-loader'; | ||
| import { logger } from '@runejs/logger/dist/logger'; | ||
| import { ActionPlugin } from '@server/plugins/plugin'; | ||
| import { Item } from '@server/world/items/item'; | ||
| import { Npc } from '@server/world/actor/npc/npc'; | ||
|
|
||
| /** | ||
| * The definition for an item on npc action function. | ||
| */ | ||
| export type itemOnNpcAction = (details: ItemOnNpcActionDetails) => void; | ||
|
|
||
| /** | ||
| * Details about an npc being interacted with. and the item being used. | ||
| */ | ||
| export interface ItemOnNpcActionDetails { | ||
| player: Player; | ||
| npc: Npc; | ||
| position: Position; | ||
| item: Item; | ||
| itemWidgetId: number; | ||
| itemContainerId: number; | ||
| } | ||
|
|
||
| /** | ||
| * Defines an item on npc interaction plugin. | ||
| * A list of npc ids that apply to the plugin, the items that can be performed on, | ||
| * and whether or not the player must first walk to the npc. | ||
| */ | ||
| export interface ItemOnNpcActionPlugin extends ActionPlugin { | ||
| npcsIds: number | number[]; | ||
| itemIds: number | number[]; | ||
| walkTo: boolean; | ||
| action: itemOnNpcAction; | ||
| } | ||
|
|
||
| /** | ||
| * A directory of all item on npc interaction plugins. | ||
| */ | ||
| let itemOnNpcInteractions: ItemOnNpcActionPlugin[] = []; | ||
|
|
||
| /** | ||
| * Sets the list of item on npc interaction plugins. | ||
| * @param plugins The plugin list. | ||
| */ | ||
| export const setItemOnNpcPlugins = (plugins: ActionPlugin[]): void => { | ||
| itemOnNpcInteractions = plugins as ItemOnNpcActionPlugin[]; | ||
| }; | ||
|
|
||
| // @TODO priority and cancelling other (lower priority) actions | ||
| export const itemOnNpcAction = (player: Player, npc: Npc, | ||
| position: Position, item: Item, itemWidgetId: number, itemContainerId: number): void => { | ||
| if (player.busy) { | ||
| return; | ||
| } | ||
|
|
||
| // Find all item on npc action plugins that reference this landscape object | ||
| let interactionPlugins = itemOnNpcInteractions.filter(plugin => pluginFilter(plugin.npcsIds, npc.id)); | ||
|
|
||
| // Find all item on npc action plugins that reference this item | ||
| if (interactionPlugins.length !== 0) { | ||
| interactionPlugins = interactionPlugins.filter(plugin => pluginFilter(plugin.itemIds, item.itemId)); | ||
| } | ||
|
|
||
| if (interactionPlugins.length === 0) { | ||
| player.outgoingPackets.chatboxMessage(`Unhandled item on npc interaction: ${item.itemId} on ${npc.name} ` + | ||
| `(id-${npc.id}) @ ${position.x},${position.y},${position.level}`); | ||
| return; | ||
| } | ||
|
|
||
| player.actionsCancelled.next(); | ||
|
|
||
| // Separate out walk-to actions from immediate actions | ||
| const walkToPlugins = interactionPlugins.filter(plugin => plugin.walkTo); | ||
| const immediatePlugins = interactionPlugins.filter(plugin => !plugin.walkTo); | ||
|
|
||
| // Make sure we walk to the npc before running any of the walk-to plugins | ||
| if (walkToPlugins.length !== 0) { | ||
| walkToAction(player, position) | ||
| .then(() => { | ||
| player.face(position); | ||
|
|
||
| walkToPlugins.forEach(plugin => | ||
| plugin.action({ | ||
| player, | ||
| npc, | ||
| position, | ||
| item, | ||
| itemWidgetId, | ||
| itemContainerId | ||
| })); | ||
| }) | ||
| .catch(() => logger.warn(`Unable to complete walk-to action.`)); | ||
| } | ||
|
|
||
| // Immediately run any non-walk-to plugins | ||
| if (immediatePlugins.length !== 0) { | ||
| immediatePlugins.forEach(plugin => | ||
| plugin.action({ | ||
| player, | ||
| npc, | ||
| position, | ||
| item, | ||
| itemWidgetId, | ||
| itemContainerId | ||
| })); | ||
| } | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to
animation-ids.ts