Implements random npc movement via a loopable queueable task #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-m-knox
commented
Sep 2, 2024
src/engine/world/actor/actor.ts
Outdated
| callbackResult: true, | ||
| shouldContinueLooping: true, | ||
| }; | ||
| }, null, { cacheOriginal: false, objectConfig: this as unknown as ObjectConfig })) // TODO: this needs to be better |
There was a problem hiding this comment.
Any suggestions on how I might pass in the actor (or just simply nothing) as an ObjectConfig here? I used an escape hatch in TS to get around the type checker, and I would prefer a better solution.
There was a problem hiding this comment.
made it possible to null this field
| @@ -212,7 +212,7 @@ export class Npc extends Actor { | |||
| if(this.metadata.following) { | |||
| return false; | |||
| } | |||
| return this.updateFlags.faceActor === undefined && this.updateFlags.animation === undefined; | |||
| return this.updateFlags.faceActor === null && this.updateFlags.animation === null; | |||
There was a problem hiding this comment.
This needed to be changed in order to allow NPC's to move. I evaluated their state during regular idle gameplay and these values were null. I am not familiar with the purpose of these so I may be breaking something here - please provide thoughts.
There was a problem hiding this comment.
nulling instead of setting undefined here seems better, since initial is null
charles-m-knox
force-pushed
the
npc-random-movements
branch
from
8971715
to
1a0c164
Compare
charles-m-knox
changed the title
Promises
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement random NPC movements, I created a new task called
QueueableTask. It is a general-purpose task that executes a callback on each tick, and also optionally allows a base task to be triggered on the next tick.I used this to implement
actor.moveSomewhere()on each tick.Please provide any thoughts in the implementation. I have only been introduced to this code base as of yesterday, so there are likely some subtleties and nuances that I have glossed over in my implementation. There might even already be an existing task/pipe/etc that implements what I implemented here, and if so, let me know.