Add NPC worldIndex to NPC update packets #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-m-knox
force-pushed
the
worldindex-npc-update-packet-announce
branch
from
123176e
to
f24e4d7
Compare
charles-m-knox
force-pushed
the
worldindex-npc-update-packet-announce
branch
from
f24e4d7
to
dc93764
Compare
charles-m-knox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 bytes (1
short) to the npc update packet that includes theworldIndexof the npc.This is (currently) necessary because the client seems to typically be unable to stay synchronized (specifically, npc order) with the server's tracked NPC list.
The existing npc update packet does not include any bytes of data to indicate which npc should be updated.
Since order isn't preserved, the packet gets processed by the client and it applies the changes incrementally to whatever NPCs it's tracking in its own order.
See accompanying PR for the client: runejs/refactored-client-435#205
edit: previously I coupled a few other changes into this PR, but since this is probably an (understandably) undesirable change, I'm going to remove the other changes into other future PRs