Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment with Async Generator for Plugin Loading. #58

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Experiment with Async Generator for Plugin Loading. #58

merged 1 commit into from
Feb 18, 2020

Conversation

Hc747
Copy link
Contributor

@Hc747 Hc747 commented Feb 18, 2020

No description provided.

@TheBlackParade
Copy link
Contributor

Some good stuff here, I'll have to play around with this a bit. Join us over on Discord if you'd like: https://discord.gg/5P74nSh :)

TheBlackParade
TheBlackParade approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@TheBlackParade TheBlackParade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, just wanted to pull it down and play around with it a bit myself before merging it in since it affects a lot. Looks great, thanks for the improvements! :shipit:

@TheBlackParade TheBlackParade merged commit 4528f08 into runejs:master Feb 18, 2020
@Hc747
Copy link
Contributor Author

Hc747 commented Feb 18, 2020

Sorry for the delay, just wanted to pull it down and play around with it a bit myself before merging it in since it affects a lot. Looks great, thanks for the improvements! :shipit:

@TheBlackParade No fuss - glad you like the change! Could even be worth extracting getFiles as a utility method, and potentially passing in a lambda expression for filtering files so as to allow for call-site specific validation logic? Only if you're needing a similar mechanism elsewhere in the project. Either way, keep up the good work & thanks for merging!

@Hc747 Hc747 deleted the plugin-loader-experiments branch February 18, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlackParade TheBlackParade TheBlackParade approved these changes

Assignees

@Hc747 Hc747

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hc747 @TheBlackParade