Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extremely simple implementation of shops. #67

Merged
merged 4 commits into from
Feb 20, 2020
Merged

Extremely simple implementation of shops. #67

merged 4 commits into from
Feb 20, 2020

Conversation

nicknick-io
Copy link
Contributor

Missing:

  1. Update the amount in the interface.
  2. A way for players to sell items, probably some sort of other inventory interface.

TheBlackParade
TheBlackParade suggested changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@TheBlackParade TheBlackParade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things

src/world/config/shops.ts Outdated
return undefined;
}

export function openShop(player: Player, identification: string, closeOnWalk: boolean = true): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer this to be it's own action as opposed to having it inside the shop config file

src/world/items/item-container.ts Outdated
@@ -59,7 +59,7 @@ export class ItemContainer {
}
}

return -1;
return undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this to undefined? That may mess with other things across the server

TheBlackParade
TheBlackParade approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@TheBlackParade TheBlackParade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TheBlackParade TheBlackParade merged commit 5cde103 into runejs:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlackParade TheBlackParade TheBlackParade approved these changes

Assignees

@nicknick-io nicknick-io

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicknick-io @TheBlackParade