-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ?disabled to be set to AsyncDirective #341
Comments
nmattia
added a commit
to dfinity/internet-identity
that referenced
this issue
Jan 8, 2024
This adds a lit-analyzer lint check. This ensures we make correct use of lit templates. We disable three rules which currently appear to be overrestrictive: * runem/lit-analyzer#341 * runem/lit-analyzer#342 * runem/lit-analyzer#343
nmattia
added a commit
to dfinity/internet-identity
that referenced
this issue
Jan 8, 2024
This adds a lit-analyzer lint check. This ensures we make correct use of lit templates. We disable three rules which currently appear to be overrestrictive: * runem/lit-analyzer#341 * runem/lit-analyzer#342 * runem/lit-analyzer#343
github-merge-queue bot
pushed a commit
to dfinity/internet-identity
that referenced
this issue
Jan 8, 2024
This adds a lit-analyzer lint check. This ensures we make correct use of lit templates. We disable three rules which currently appear to be overrestrictive: * runem/lit-analyzer#341 * runem/lit-analyzer#342 * runem/lit-analyzer#343
This is a great issue. I can definitely investigate this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like
lit-analyzer
disallows setting?disabled
to an async directive. It will throwno-invalid-directive-binding
:In practice
lit
(andlit-html
) do not seem to have an issue with this, as shown by this playground example:The text was updated successfully, but these errors were encountered: