Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add High Score Functionality #50

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add High Score Functionality #50

wants to merge 15 commits into from

Conversation

SpamMusubi153
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 14, 2022 •
edited
Loading

✅ Deploy Preview for flying-cube-game ready!

Name Link
🔨 Latest commit 4b58f2a
🔍 Latest deploy log https://app.netlify.com/sites/flying-cube-game/deploys/62f9d091ede5fd00082311f9
😎 Deploy Preview https://deploy-preview-50--flying-cube-game.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SpamMusubi153 SpamMusubi153 changed the title Add and Update a High Score Counter Variable Add High Score Functionality Aug 14, 2022
@SpamMusubi153
Copy link
Contributor Author

This commit solves issue #22.

@SpamMusubi153 SpamMusubi153 mentioned this pull request Aug 14, 2022
Open
runewake2
runewake2 requested changes Aug 14, 2022
View reviewed changes
Copy link
Owner

@runewake2 runewake2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a syntax error caused by scoping in this right now. If you fix that I think this should work nicely!

game/src/hud.js Outdated Show resolved Hide resolved
@SpamMusubi153
Change Scope of hudTexture
402355d
@SpamMusubi153
Update the HUD High Score Text
9f9d2fc 
Update the HUD High Score Text to only display the high score text once when the score is first updated.
@SpamMusubi153
Remove Extraneous Variables
4b58f2a
@SpamMusubi153 SpamMusubi153 reopened this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runewake2 runewake2 runewake2 requested changes

@jimbobbennett jimbobbennett Awaiting requested review from jimbobbennett jimbobbennett is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpamMusubi153 @runewake2