Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ECR credential integration into Finch #462

Merged
merged 21 commits into from
Jul 17, 2023
Merged

feat: ECR credential integration into Finch #462

merged 21 commits into from
Jul 17, 2023

Commits on Jul 3, 2023

  1. added credential helper integration 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0d287cc View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. added integration test, removed extra line from bash rc 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1653c5f View commit details
    Browse the repository at this point in the history

  2. removed focus from test 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e76bd81 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. added registry flag to makefile, added note in readme, removed popula… 

    …ting config.json in integration test, changed binares struct to credhelperbin

Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    82fcbe6 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. added go mod and go sum 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ec78355 View commit details
    Browse the repository at this point in the history

  2. removed nested describe node, linter changes 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bfd4294 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. added support for credentials as env variables, style changes 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    3706612 View commit details
    Browse the repository at this point in the history

  2. linter change 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c5443ff View commit details
    Browse the repository at this point in the history

  3. updated ci workflow to support credhelper integration test 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    1f73b57 View commit details
    Browse the repository at this point in the history

  4. updated secret used in make for e2e test 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b812a12 View commit details
    Browse the repository at this point in the history

  5. changed REGSITRY from secret to env 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4dc9480 View commit details
    Browse the repository at this point in the history

  6. added permissions param to ci 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    981d566 View commit details
    Browse the repository at this point in the history

  7. added if statement to configure aws creds 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5912857 View commit details
    Browse the repository at this point in the history

  8. added back session name 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5ee0833 View commit details
    Browse the repository at this point in the history

  9. added ci logic 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ba8cbe4 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Merge branch 'main' into dev

    @kiryl1
    kiryl1 authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f994666 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. changed option credsHelper to creds_helpers for consistency, added do… 

    …cs to README, changed data type of credential helper to a slice instead of just string

Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    acc65fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' of https://github.com/kiryl1/finch into dev

    @kiryl1
    kiryl1 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    61bd4fa View commit details
    Browse the repository at this point in the history

  3. removed redundant nil check, removed unneeded docs in README 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    031c50a View commit details
    Browse the repository at this point in the history

  4. linter fix 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    de1786b View commit details
    Browse the repository at this point in the history

  5. updated readme 

    Signed-off-by: kiryl1 <kirylkul@gmail.com>
    @kiryl1
    kiryl1 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    949a184 View commit details
    Browse the repository at this point in the history