Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refresh contributing guide (windows dev setup and auto-gen cmd docs) #960

Merged
merged 2 commits into from
May 28, 2024

Conversation

pendo324
Copy link
Member

Issue #, if available: #942

Description of changes:

  • Update contribution docs to reflect changes over the past few months:
    • Windows dev setup
    • Doc updates when commands change

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…docs)

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324 pendo324 self-assigned this May 24, 2024
Shubhranshu153
Shubhranshu153 previously approved these changes May 24, 2024
coderbirju
coderbirju previously approved these changes May 24, 2024
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324 pendo324 dismissed stale reviews from coderbirju and Shubhranshu153 via d957d5d May 24, 2024 21:16
@pendo324 pendo324 requested a review from a team as a code owner May 24, 2024 21:16
@pendo324
Copy link
Member Author

Funnily enough, fixing the docs CI job which is supposed to allow doc only changes to skip running the full e2e tests caused the full e2e tests to run

@pendo324 pendo324 merged commit d3c4165 into runfinch:main May 28, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants