Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(view): change database data source binding #944

Merged
merged 5 commits into from
Mar 8, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions frontend/src/app/migration/MigrationEvent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { APP_VERSION_INIT } from './constants';
import { IDomainEvent, Task } from './types';

/**
* Migrtion Event
* Migration Event
* @class MigrationTaskEvent
* @template TDomainModel
*/
Expand Down Expand Up @@ -48,12 +48,12 @@ class MigrationEvent<TDomainModel extends { version?: string }>
}
return result;
} catch (error) {
// TODO(Stephen): beautiful console format
console.error(
'Migration Event Error | Version: %s | Stack Trace: %o',
console.log(
'%c Datart Migration Error | Version: %s | Please Contract Administrator! ',
'background: red; color: #fafafa',
this.version,
error,
);
console.log('Migration Event Error | Stack Trace: %o', error);
throw error;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,58 +28,71 @@ import { Col, Input, Row } from 'antd';
import { Tree } from 'app/components';
import useI18NPrefix from 'app/hooks/useI18NPrefix';
import { useSearchAndExpand } from 'app/hooks/useSearchAndExpand';
import { selectDataProviderDatabaseListLoading } from 'app/pages/MainPage/slice/selectors';
import { getDataProviderDatabases } from 'app/pages/MainPage/slice/thunks';
import { DEFAULT_DEBOUNCE_WAIT } from 'globalConstants';
import { memo, useCallback, useContext, useEffect } from 'react';
import { memo, useCallback, useContext, useEffect, useMemo } from 'react';
import { monaco } from 'react-monaco-editor';
import { useDispatch, useSelector } from 'react-redux';
import styled from 'styled-components/macro';
import { SPACE_MD, SPACE_XS } from 'styles/StyleConstants';
import { RootState } from 'types';
import { request } from 'utils/request';
import { errorHandle } from 'utils/utils';
import { ColumnTypes } from '../../constants';
import { EditorContext } from '../../EditorContext';
import { useViewSlice } from '../../slice';
import {
selectCurrentEditingViewAttr,
selectDatabases,
selectSourceDatabaseSchemas,
} from '../../slice/selectors';
import { getEditorProvideCompletionItems } from '../../slice/thunks';
import { Schema } from '../../slice/types';
import { DatabaseSchema } from '../../slice/types';
import { buildAntdTreeNodeModel } from '../../utils';
import Container from './Container';

export const Resource = memo(() => {
const { actions } = useViewSlice();
const t = useI18NPrefix('view.resource');
const dispatch = useDispatch();
const { editorCompletionItemProviderRef } = useContext(EditorContext);
const sourceId = useSelector<RootState>(state =>
selectCurrentEditingViewAttr(state, { name: 'sourceId' }),
) as string;
const databases = useSelector(state =>
selectDatabases(state, { name: sourceId }),
);
const databaseListLoading = useSelector(
selectDataProviderDatabaseListLoading,
const databaseSchemas = useSelector(state =>
selectSourceDatabaseSchemas(state, { id: sourceId }),
);
const t = useI18NPrefix('view.resource');

const buildTableNode = useCallback((database: DatabaseSchema) => {
const children =
database?.tables?.map(table => {
return buildTableColumnNode([database.dbName], table);
}) || [];

return buildAntdTreeNodeModel([], database.dbName, children, false);
}, []);

const buildTableColumnNode = (ancestors: string[] = [], table) => {
const children =
table?.columns?.map(column => {
return buildAntdTreeNodeModel(
ancestors.concat(table.tableName),
column?.name,
[],
true,
);
}) || [];
return buildAntdTreeNodeModel(ancestors, table.tableName, children, false);
};

const databaseTreeModel = useMemo(() => {
return (databaseSchemas || []).map(buildTableNode);
}, [buildTableNode, databaseSchemas]);

const { filteredData, onExpand, debouncedSearch, expandedRowKeys } =
useSearchAndExpand(
databases,
databaseTreeModel,
(keywords, data) => (data.title as string).includes(keywords),
DEFAULT_DEBOUNCE_WAIT,
true,
);
useEffect(() => {
if (sourceId && !databases) {
dispatch(getDataProviderDatabases(sourceId));
}
}, [dispatch, sourceId, databases]);

useEffect(() => {
if (databases && editorCompletionItemProviderRef) {
if (databaseTreeModel && editorCompletionItemProviderRef) {
editorCompletionItemProviderRef.current?.dispose();
dispatch(
getEditorProvideCompletionItems({
Expand All @@ -93,54 +106,7 @@ export const Resource = memo(() => {
}),
);
}
}, [dispatch, sourceId, databases, editorCompletionItemProviderRef]);

const loadData = useCallback(
({ value }) =>
new Promise<void>((resolve, reject) => {
try {
const [database, table] = value;
if (table) {
request<Schema[]>(
`/data-provider/${sourceId}/${database}/${table}/columns`,
).then(({ data }) => {
dispatch(
actions.addSchema({
sourceId,
databaseName: database,
tableName: table,
schema: data,
}),
);
resolve();
});
} else {
request<string[]>(
`/data-provider/${sourceId}/${database}/tables`,
).then(({ data }) => {
dispatch(
actions.addTables({
sourceId,
databaseName: database,
tables: data.sort((a, b) =>
a.toLowerCase() < b.toLowerCase()
? -1
: a.toLowerCase() > b.toLowerCase()
? 1
: 0,
),
}),
);
resolve();
});
}
} catch (error) {
errorHandle(error);
reject();
}
}),
[dispatch, sourceId, actions],
);
}, [dispatch, sourceId, databaseTreeModel, editorCompletionItemProviderRef]);

const renderIcon = useCallback(({ value }) => {
if (Array.isArray(value)) {
Expand Down Expand Up @@ -179,8 +145,7 @@ export const Resource = memo(() => {
<Tree
className="medium"
treeData={filteredData}
loadData={loadData}
loading={databaseListLoading}
loading={false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

切换 sourceId 时,databaseSchemas 会重新加载,loading 状态应该加上

icon={renderIcon}
selectable={false}
defaultExpandedKeys={expandedRowKeys}
Expand Down
14 changes: 9 additions & 5 deletions frontend/src/app/pages/MainPage/pages/ViewPage/slice/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
import { createSlice, PayloadAction } from '@reduxjs/toolkit';
import { getDataProviderDatabases } from 'app/pages/MainPage/slice/thunks';
import { useInjectReducer } from 'utils/@reduxjs/injectReducer';
import { isMySliceRejectedAction } from 'utils/@reduxjs/toolkit';
import { rejectedActionMessageHandler } from 'utils/notification';
import { ViewViewModelStages } from '../constants';
import {
diffMergeHierarchyModel,
Expand Down Expand Up @@ -399,15 +401,17 @@ const slice = createSlice({
});

builder.addCase(getSchemaBySourceId.fulfilled, (state, action) => {
if (!action.payload?.data) {
if (!action.payload?.data?.schemaItems) {
return;
}
if (!state.sourceDatabaseSchema) {
state.sourceDatabaseSchema = {};
}
state.sourceDatabaseSchema[action.payload?.sourceId] =
action.payload.data;
action.payload.data.schemaItems;
});

builder.addMatcher(
isMySliceRejectedAction(slice.name),
rejectedActionMessageHandler,
);
},
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { listToTree } from 'utils/utils';
import { initialState } from '.';
import { ResourceTypes } from '../../PermissionPage/constants';
import {
DatabaseSchema,
SelectViewFolderTreeProps,
SelectViewTreeProps,
ViewViewModel,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -359,10 +359,10 @@ export const getEditorProvideCompletionItems = createAsyncThunk<
const variableKeywords = new Set<string>();

if (sourceId) {
const databaseSchemas = selectSourceDatabaseSchemas(getState(), {
const currentDBSchemas = selectSourceDatabaseSchemas(getState(), {
id: sourceId,
});
databaseSchemas?.schemaItems?.forEach(db => {
currentDBSchemas?.forEach(db => {
dbKeywords.add(db.dbName);
db.tables?.forEach(table => {
tableKeywords.add(table.tableName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface ViewState {
[name: string]: TreeDataNode[];
};
sourceDatabaseSchema: {
schemaItems?: DatabaseSchema[];
[name: string]: DatabaseSchema[];
};
saveViewLoading: boolean;
unarchiveLoading: boolean;
Expand Down
18 changes: 18 additions & 0 deletions frontend/src/app/pages/MainPage/pages/ViewPage/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* limitations under the License.
*/

import { TreeDataNode } from 'antd';
import { FONT_WEIGHT_MEDIUM, SPACE_UNIT } from 'styles/StyleConstants';
import { Nullable } from 'types';
import { isEmptyArray } from 'utils/object';
Expand Down Expand Up @@ -376,3 +377,20 @@ export const diffMergeHierarchyModel = (model: HierarchyModel) => {
model.hierarchy = newHierarchy;
return model;
};

export function buildAntdTreeNodeModel<T extends TreeDataNode & { value: any }>(
ancestors: string[] = [],
nodeName: string,
children?: T[],
isLeaf?: boolean,
): T {
const TREE_HIERARCHY_SEPERATOR = String.fromCharCode(0);
const fullNames = ancestors.concat(nodeName);
return {
key: fullNames.join(TREE_HIERARCHY_SEPERATOR),
title: nodeName,
value: fullNames,
children,
isLeaf,
} as any;
}