Added code to handle non-image uploads in runpod.serverless.utils.rp_upload.files(...) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmerrell
requested changes
Oct 6, 2023
runpod/serverless/utils/rp_upload.py
Outdated
| from boto3 import session | ||
| from boto3.s3.transfer import TransferConfig | ||
| from botocore.config import Config | ||
| from tqdm_loggable.auto import tqdm | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Everything else looks good, I almost feel bad asking for the one change to get rid of this extra blank line :)
|
Solid contribution, just a super minor nit-picking change request and then it should be good to merge :) |
|
I'd say a solid 50% of my code base is extra blank lines - happy to remove one or two! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing upload code assumes that the user is trying to upload an image, and forces the S3 content type to PNG regardless of what the file actually is.
This version first tries an image-based approach, setting the content type by the image type, and then falls back to a file-based upload.
Any exceptions caused by anything other than PIL detecting it's not an image will still be handled in the remainder of the code.