Hs dependency upgrade #4094
Draft
Hs dependency upgrade #4094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes custom dependency on `hashable-1.4.2` * Removes the `time-profile` tool from `dev-tools`: we don't use it actively and its dependency `profiteur` creates problems. * Disables the (new) warnings about partial functions (`-Wx-partial`) in `kore` where some `head/tail` instances are used. The code should be remediated and the warning re-enabled.
jberthold
force-pushed
the
hs-dependency-upgrade
branch
from
72b3f62 to
b80955f
Compare
jberthold
force-pushed
the
hs-dependency-upgrade
branch
from
b80955f to
a7b03d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades HS backend build to ghc-9.8.4 and stackage LTS-23.9
hashablerequired any moretime-profileapp which brought in theprofiteurdependency (not maintained, problematic dependencies)hlintandfourmoluin the nix derivation -> minor code changesheadandtailin GHC: code changes to avoid them-Wno-x-partialcould be used but can for some reason not be configured inkore.cabal(stack build --pedanticseems to override it with-Wall -Werrorlater in the command line - not visible in verbose output)This currently fails with a segfault in the LLVM compilation during integration tests. The reason is unclear, it happens locally, too, under nix.
Before merging this
rv-nix-envto use the chosennixpkgshash globally, and revert the local change herenixpkgssetting in various downstream packages