Add test runner python module

[anvacaru]

Writing tests

• First, the module pyiele needs to be imported.
• The default values for the client port, passphrase, spending-key, gas-limit and other parameters are defined in the config.py file.
• A contract can be deployed using deploy_contract(walletId, sender, bytecode).
• A contract function can be called using run_function(f_name, f_args, walletId, sender, to).
• Any rpc call can be made using send(rpc).
• RPC calls are defined in rpc.py.

Running tests

>$ python3 test_erc20.sol

[ehildenb]

@anvacaru and @gtrepta can we add some tests of this functionality as well? Just a single Solidity file -> generated report files, and diff the files should be enough.

Or we can just make sure the tool runs smoothly, and not record the output, as an initial test. But it probably would be better to start with too strong of testing (with the output files) and weaken it as it gets annoying.

[ehildenb]

Suggested change

	run_pyiele() {
	python3 -m pyiele "$@"
	}
	run_pyiele() {
	python3 -m pyiele --host "${host}" --port "${port}" --output "${output_path}" "$@"
	}

[gtrepta]

This will have to be

python3 -m pyiele "$@" --host "${host}" --port "${port}" --output "${output_path}"

Because the command {blackbox,test,compile,coverage} is a positional parameter.

[gtrepta]

On second look, this might not work at all. None of these parameters are included in all of the commands.

[anvacaru]

I was able to set the run_pyiele() function to Everett's suggestion by moving the port,host, and output parameters to the main parser (initially, they were subparser parameters).

[ehildenb]

Suggested change

	run_testrunner() {
	local run_file
	if [[ $# -gt 0 ]] && [ "$1" == "--help" ]; then
	run_pyiele test --help
	exit
	fi
	if ! nc -z "$kiele_host" "$kiele_port"; then
	fatal "No listener found on port $kiele_port"
	fi
	if [[ $# -gt 0 ]]; then
	if [[ -f "$1" ]] || [[ -d "$1" ]]; then
	run_file="$1"; shift
	if [[ "$run_file" == *.py ]]; then
	python3 "$run_file"
	else
	run_pyiele test --file "$run_file" --port "$kiele_port" "$@"
	fi
	else
	run_pyiele test --port "$kiele_port" "$@"
	fi
	else
	run_pyiele test --port "$kiele_port" "$@"
	fi
	}
	run_testrunner() {
	! nc -z "$kiele_host" "$kiele_port" || fatal "No listener found on port $kiele_port"
	run_pyiele test "$@"
	}

[gtrepta]

My suggestion:

Suggested change

	run_testrunner() {
	local run_file
	if [[ $# -gt 0 ]] && [ "$1" == "--help" ]; then
	run_pyiele test --help
	exit
	fi
	if ! nc -z "$kiele_host" "$kiele_port"; then
	fatal "No listener found on port $kiele_port"
	fi
	if [[ $# -gt 0 ]]; then
	if [[ -f "$1" ]] || [[ -d "$1" ]]; then
	run_file="$1"; shift
	if [[ "$run_file" == *.py ]]; then
	python3 "$run_file"
	else
	run_pyiele test --file "$run_file" --port "$kiele_port" "$@"
	fi
	else
	run_pyiele test --port "$kiele_port" "$@"
	fi
	else
	run_pyiele test --port "$kiele_port" "$@"
	fi
	}
	run_testrunner() {
	local run_file cmd
	if [[ $# -gt 0 ]] && [ "$1" == "--help" ]; then
	run_pyiele test --help
	exit
	fi
	if ! nc -z "$kiele_host" "$kiele_port"; then
	fatal "No listener found on port $kiele_port"
	fi
	cmd=(run_pyiele test --port "$kiele_port" --host "$kiele_host")
	if [[ $# -gt 0 ]] && ([[ -f "$1" ]] || [[ -d "$1" ]]); then
	run_file="$1"; shift
	if [[ "$run_file" == *.py ]]; then
	cmd=( python3 "$run_file" )
	else
	cmd+=( --file "$run_file" )
	fi
	fi
	"${cmd[@]}" "$@"
	}

[ehildenb]

The --help option should be handled once globally at the top, and if we want it to call the pyiele help there as well, then it should do that.

But we shouldn't duplicate all this stuff about calling help everywhere.

[anvacaru]

I agree with @ehildenb. Initially, I added explicit help calls because the check_listener would prevent the help message from being displayed if the midnight client wasn't active. For now I just removed all explicit calls.

[ehildenb]

Factor out a check_listener function in the Utilities section at the top, and use that.

[anvacaru]

Done.